Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add should_run for convs instead of panicking #2403

Merged
merged 7 commits into from
Oct 23, 2024

Conversation

ArthurBrussee
Copy link
Contributor

Changes

Conv2D currently panic in im2col / col2im for images that are too large when autotuning. This works ok on std as tuning uses catch_unwind, but this crashes on wasm.

Testing

Running some convs on wasm, doesn't crash anymore!

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 16 lines in your changes missing coverage. Please review.

Project coverage is 85.25%. Comparing base (80c831b) to head (6705120).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/burn-jit/src/kernel/conv/conv2d/implicit_gemm.rs 42.10% 11 Missing ⚠️
crates/burn-jit/src/kernel/conv/conv2d/im2col.rs 75.00% 3 Missing ⚠️
...tes/burn-jit/src/kernel/conv/conv2d/tune/conv2d.rs 96.66% 1 Missing ⚠️
...it/src/kernel/conv/conv2d/tune/conv_transpose2d.rs 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2403      +/-   ##
==========================================
- Coverage   85.26%   85.25%   -0.01%     
==========================================
  Files         792      792              
  Lines      104516   104552      +36     
==========================================
+ Hits        89115    89140      +25     
- Misses      15401    15412      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanielsimard nathanielsimard merged commit bac4405 into tracel-ai:main Oct 23, 2024
11 checks passed
@ArthurBrussee ArthurBrussee deleted the tune-panic branch October 23, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants