Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bounds checking to implicit GEMM to allow arbitrary input shapes #2354

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

wingertge
Copy link
Contributor

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Changes

Implicit GEMM was previously only padded on the input channel, now all 3 dimensions get implicitly padded to allow arbitrary sized inputs. The performance of the padded convolutions is slightly slower than the next matching size, but still faster than other convolution strategies.

Testing

All tests pass with implicit GEMM except the ones with groups.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 22.03390% with 92 lines in your changes missing coverage. Please review.

Project coverage is 85.05%. Comparing base (ce7d866) to head (ec8a356).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...s/burn-jit/src/kernel/conv/conv2d/implicit_gemm.rs 22.03% 92 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2354      +/-   ##
==========================================
- Coverage   85.06%   85.05%   -0.01%     
==========================================
  Files         769      769              
  Lines       98702    98732      +30     
==========================================
+ Hits        83959    83976      +17     
- Misses      14743    14756      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louisfd louisfd merged commit c21e096 into tracel-ai:main Oct 11, 2024
11 checks passed
@wingertge wingertge deleted the feat/implicit-gemm-for-all branch October 14, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants