Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dim checks on output rank for unsqueeze_dim and stack #2331

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

laggui
Copy link
Member

@laggui laggui commented Oct 2, 2024

Checklist

  • Confirmed that run-checks all script has been executed.

Related Issues/PRs

Fixes #2329 (better help message)

Changes

Added checks for output rank with unsqueeze_dim and stack checks.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 67.85714% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.36%. Comparing base (99d9fa2) to head (7b9f59c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-tensor/src/tensor/api/check.rs 65.38% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2331      +/-   ##
==========================================
- Coverage   85.37%   85.36%   -0.01%     
==========================================
  Files         768      769       +1     
  Lines       98673    98692      +19     
==========================================
+ Hits        84238    84249      +11     
- Misses      14435    14443       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laggui laggui merged commit 8327deb into main Oct 4, 2024
11 checks passed
@laggui laggui deleted the fix/tensor/check branch October 4, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when stacking tensors (images as u8)
1 participant