simplify scope tracking in burn-import #2207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks all
script has been executed.Changes
Something from #2008 worth keeping around. Scopes was storing variable references as a vector, but then only storing one Tensor Variable in each entry. I changed scopes to be a single
TensorVariable
per entry. Makes it a little easier to understand at a glance.the other change was to check the graph outputs and the graph inputs in the same iteration when scope checking. Since the graph is a DAG, that's guaranteed not to break.
Testing
I ran
test -p burn-import
,test -p onnx-test
, andtypos crates/burn-import
. This should cover all the relevant test from run checks all