-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: burn-import implement ONNX ConstantOfShape #1815
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1815 +/- ##
==========================================
- Coverage 85.50% 85.38% -0.13%
==========================================
Files 811 821 +10
Lines 100401 101427 +1026
==========================================
+ Hits 85848 86603 +755
- Misses 14553 14824 +271 ☔ View full report in Codecov by Sentry. |
c224e40
to
dbe0a87
Compare
dbe0a87
to
43e70f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of changes needed to follow the spec, but otherwise a great start! 💪
crates/burn-import/onnx-tests/tests/constant_of_shape/constant_of_shape.py
Outdated
Show resolved
Hide resolved
This PR has been marked as stale because it has not been updated for over a month |
I will take over this PR and fix issues. |
@skewballfox, if you have a chance, please take a look at this PR. I started using Shape arg type instead of using Tensor because shape operation is outside tensor operation but ONNX treats them as if they tensors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed unresolved issues and started using Shape ArgType which we had but didn't use it. I am approving since I looked at the code and fixed issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still an issue with the generated ONNX model for the tests.
Otherwise LGTM!
crates/burn-import/onnx-tests/tests/constant_of_shape/constant_of_shape.py
Outdated
Show resolved
Hide resolved
Thanks; sorry, I had other things preventing me from finishing this. |
No worries! This happens. Thanks for starting it and contributing. Now it's done. |
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
Although
ConstantOfShape
is not explicitly there, this still benefits #1714Changes
Add
ConstantOfShape
support to onnx import.Testing
Codegen and overall import tests as described in the contributor book.