feat: added min onnx import #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosure
approved these changes
May 17, 2024
nathanielsimard
approved these changes
May 22, 2024
laggui
approved these changes
May 22, 2024
JachymPutta
force-pushed
the
jp/min_onnx_import
branch
from
276a041 to
3a36207
Compare
|
Thank you 🙏 Will merge when CI is done. |
|
Great! Thank you:) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1778 +/- ##
=======================================
Coverage 86.41% 86.42%
=======================================
Files 737 737
Lines 86099 86131 +32
=======================================
+ Hits 74406 74437 +31
- Misses 11693 11694 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed. (doc errors, many jit tests failing)Related Issues/PRs
Provide links to relevant issues and dependent PRs.
Changes
Adding the min operator to onnx-import
Testing
Done manually with:
cargo test min