Refactor/burn compute #1580
Merged
Refactor/burn compute #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisfd
requested changes
Apr 17, 2024
crates/burn-compute/src/id.rs
Outdated
| @@ -25,26 +33,134 @@ macro_rules! storage_id_type { | |||
| }; | |||
| } | |||
|
|
|||
| /// Reference to buffer handles, to be holded by a tensor. | |||
crates/burn-compute/src/id.rs
Outdated
| all: Arc<()>, | ||
| } | ||
|
|
||
| /// Reference to buffer handles, to be holded by anything else than tensors. |
crates/burn-compute/src/id.rs
Outdated
| #[macro_export(local_inner_macros)] | ||
| /// Create a new memory ID type. | ||
| /// Create a new memory ID types. |
There was a problem hiding this comment.
not sure why you added plural, but you should at least remove the "a"
| storage: StorageHandle, | ||
| handle: SliceTensorBufHandle, | ||
| // It is important to keep the chunk handle inside the slice, since it increases the ref count | ||
| // on the chunk id and make the `is_free` method returns false until the slice is freed. |
There was a problem hiding this comment.
makes the is_free method return
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1580 +/- ##
==========================================
+ Coverage 86.42% 86.44% +0.01%
==========================================
Files 694 696 +2
Lines 80687 80960 +273
==========================================
+ Hits 69731 69982 +251
- Misses 10956 10978 +22 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a single handle we now have: