-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tensor expand operator #1508
Tensor expand operator #1508
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1508 +/- ##
==========================================
+ Coverage 85.88% 85.91% +0.02%
==========================================
Files 661 663 +2
Lines 74876 75446 +570
==========================================
+ Hits 64307 64816 +509
- Misses 10569 10630 +61 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small things related to autodiff, otherwise looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much to add to the others' comments. I was also confused by the constant switch between expand <-> broadcast but it seems that it will be addressed.
To be fair, in pytorch tensor.expand(shape)
is equivalent to torch.broadcast_to(tensor, shape)
.
I noticed the docstrings still used "broadcast" but it makes sense since they're only meant to explain the function.
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
fixes #1412
Changes
Testing
New unit tests