[backend-comparison] Refresh access token and display authenticated user name #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to refresh token to be able to renew an expired access token.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1483 +/- ##
==========================================
+ Coverage 85.75% 85.76% +0.01%
==========================================
Files 647 655 +8
Lines 72300 73251 +951
==========================================
+ Hits 61998 62823 +825
- Misses 10302 10428 +126 ☔ View full report in Codecov by Sentry. |
syl20bnr
force-pushed
the
feat/refresh-access-token-display-nickname
branch
2 times, most recently
from
894b247 to
29c82ae
Compare
syl20bnr
force-pushed
the
feat/refresh-access-token-display-nickname
branch
2 times, most recently
from
0156daf to
c3b37e0
Compare
syl20bnr
force-pushed
the
feat/refresh-access-token-display-nickname
branch
from
2b9240b to
c9a9def
Compare
|
@nathanielsimard ready for another round. |
syl20bnr
force-pushed
the
feat/refresh-access-token-display-nickname
branch
2 times, most recently
from
3dbfc8b to
5db22b0
Compare
The reqwest must have an explicit empty body otherwise the release build returns a 411 when refreshing the tokens without even calling the benchmark server endpoint.
nathanielsimard
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
#1072
Changes
Add automatic refresh of access token. Now both the access token and the refresh token are cached. The refresh is done by the user benchmark server.
A new endpoint
/users/mein the user benchmark server returns the anonymized user name so that we can display it when executingburnbench auth.The
authcommand is now idempotent and can also refresh the access token so the CLI should now ask for the user's authorization only when strictly required.Testing
Tested with a local stack.