Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_close and all_close tensor operators #1389

Merged
merged 10 commits into from
Mar 1, 2024
Merged

Conversation

antimora
Copy link
Collaborator

@antimora antimora commented Mar 1, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

  1. Fixes Implement all_close and is_close tensor operator #1379
  2. Is blocked by Tensor all operator results is incorrect on burn-wgpu when using with lower_equal #1388 bug

Changes

Add is_close and all_close tensor operators.

Testing

New unit testing.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.54%. Comparing base (201e7f8) to head (c67fb3b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1389      +/-   ##
==========================================
+ Coverage   85.52%   85.54%   +0.01%     
==========================================
  Files         594      595       +1     
  Lines       68252    68280      +28     
==========================================
+ Hits        58374    58409      +35     
+ Misses       9878     9871       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antimora antimora requested a review from laggui March 1, 2024 20:32
Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@louisfd
Copy link
Member

louisfd commented Mar 1, 2024

@antimora Seems there's a conflict with main? Can you fix it then we can merge

@antimora antimora merged commit d43a0b3 into tracel-ai:main Mar 1, 2024
14 checks passed
@antimora antimora deleted the allclose branch March 1, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement all_close and is_close tensor operator
2 participants