fix/docs/chunk #1006
Merged
fix/docs/chunk #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@louisfd unfortunately no, it should hold true. The last tensor should've had 9 items and the others 13. My aim was to match the API that's expected from other ML libraries. I'll can take a look later today and make sure this test also passes. |
|
As mentioned I can look later today, but if you wanna change it in this PR you can as well :) |
|
All right, I hesitated between fixing the code or the doc! |
|
@dcvz now it should have the right behaviour |
dcvz
approved these changes
Nov 27, 2023
nathanielsimard
approved these changes
Nov 29, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dcvz
I was a bit late to review your chunk operation. It's very nice but I found something was wrong with the doc. I made a test that explains why I'm changing it. Is this the behaviour you want?