Improvements to runtests.py + use github actions as CI #140
Conversation
This helps running the tests on machines where git is configured with a different defaut branch name.
The Python documentation says not to do that, and the pipe doesn't seem to be used here anyway.
This makes the code a tiny bit more readable, and could make mocking/stubbing the actual git respository easier down the line.
Some git configurations (like mine, as it turns out) don't include that directory when using git init.
|
@neverpanic What do you think? Is this kind of PR something you're interested in? |
| COVERAGE = options.with_coverage | ||
| SHOW_LOG = options.with_trac_log | ||
|
|
||
| if options.virtualenv: |
There was a problem hiding this comment.
I'm not opposed to this, but I'm wondering if the better solution isn't to run the runtests.py script in the virtualenv itself, where $PATH would hopefully already include the correct instances of trac-admin, tracd, and coverage?
The test script itself already has quite a few dependencies and does import parts of trac, so running it outside of a virtualenv is probably not a very good idea anyway.
Maybe I'm missing a use case that you had in mind?
There was a problem hiding this comment.
Nevermind, I noticed that --with-coverage does not work when run in a virtualenv, likely because coverage run --append --branch --source=tracext.github TRACD_BIN doesn't work unless TRACD_BIN is an absolute path.
We could change that to look up tracd in $PATH in startTracd, though.
There was a problem hiding this comment.
I was juggling with multiple virtualenvs and instead of activating them I'd call the tests with path/to/venv/bin/python runtests.py which didn't seem to detect the correct path for tracd and trac-admin, hence why I added the flag.
It's very possible there's a better solution to this, but this is the one I came up with 😅
Hi,
While looking at issue #136 I ended up running into issues trying to run the test suite to make sure my changes hadn't broken anything. One thing led to another and I found myself tweaking the
runtests.pybit by bit, and eventually configuring github actions to run.I figured I would send this back upstream. If the maintainer team is not interested, feel free to close this.
I've split the PR into (mostly) independent commits that can be reviewed/merged one at a time if it makes things easier.
For a bit of context behind my contribution, we use
trac-githubon our Trac instance and I've recently started upgrading our old version, running into compatibility issues along the way (as expected). Eventually I'd like to get to Trac 1.6 and Python 3 so I would probably be submitting more PR your way if that's ok (hence why I left a commented out github action for python 3 support)