HorizontalPortrait: Support Kubernetes CronJob as external horizontal portrait algorithm job #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayko2019
added
the
kind/feature
zqzten
requested changes
Jul 5, 2023
pkg/portrait/algorithm/externaljob/jobcontroller/cron_job_test.go
Outdated
Show resolved
Hide resolved
dayko2019
force-pushed
the
external_algorithm_cron_job
branch
2 times, most recently
from
eeb9dd4 to
22fb625
Compare
zqzten
requested changes
Jul 6, 2023
dayko2019
force-pushed
the
external_algorithm_cron_job
branch
from
22fb625 to
0ca385b
Compare
zqzten
requested changes
Jul 6, 2023
dayko2019
force-pushed
the
external_algorithm_cron_job
branch
3 times, most recently
from
0dd80e0 to
2a88e23
Compare
dayko2019
force-pushed
the
external_algorithm_cron_job
branch
from
2a88e23 to
5190ed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
CronJob is a lightweight way to run complex long-running algorithms.
Which issue(s) this PR fixes:
Fixes #37
Special notes for your reviewer: