Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: derive Reply macro now uses kameo Infallible instead of () #92

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

meowjesty
Copy link
Contributor

I believe the derive macro using type Error = () was not intended? I was getting some annoying errors saying that the error did not implement Display, and this was the cause.

std types implement Reply with kameo::error::Infallible, so this PR changes the derive Reply macro to do the same.

@tqwewe
Copy link
Owner

tqwewe commented Dec 14, 2024

Looks like its something that was forgotten! I think previously I used () because kameo didn't have its own Infallible type, and was using std::convert::Infallible which doesn't impl Serialize/Deserialize.

I'll try this change out on some of my existing code base which uses kameo to see if there's any issues, but should be a nice improvement

@tqwewe tqwewe merged commit fcd9987 into tqwewe:main Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants