Hide remote actor functionality behind "remote" feature #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shusvr
changed the title
tqwewe
requested changes
Oct 9, 2024
There was a problem hiding this comment.
This is great! Thank you for taking the time to do this 😍
I'm not sure that docs.rs will recognise enable a feature = "doc" flag. I belive these annotations should instead be #[cfg_attr(docsrs, ...)] instead based on the docs here:
https://docs.rs/about/builds.
However, it seems like we can just put:
#![cfg_attr(docsrs, feature(doc_auto_cfg))]And none of the types need to be annotated with:
#[cfg_attr(feature = "doc", doc(cfg(feature = "remote")))]This cleans things up a lot, making the feature gating in the docs automatically detected!
|
Actually |
tqwewe
approved these changes
Oct 9, 2024
tqwewe
added a commit
that referenced
this pull request
Oct 9, 2024
Co-authored-by: Ari Seyhun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58
Not sure if I made all unnecessary dependencies optional, maybe you'll have some suggestions on which other dependencies can be disabled.