Add compatibility with Dash v0.13

[UdjinM6]

This adds compatibility with Dash v0.13, see more info about this release in Dash Core repo https://github.com/dashpay/dash/releases/tag/v0.13.0.0

DISCLAIMER: I'm not very familiar with the codebase and I have NOT tested this. I also wasn't able to compile the original code on my mac and thus this patch might have some stupid typos or smth like that and won't even compile. (EDIT: Travis seems to be able to compile it and all looks good) Pls try compiling and running this at least on testnet before merging.

[crackfoo]

Some info about the payload:

https://github.com/dashpay/dips/blob/master/dip-0002.md

A table w/special TX types here:
https://github.com/dashpay/dips/blob/master/dip-0002-special-transactions.md

[pinpins]

Will try to compile, and run on testnet tonight

[pinpins]

I think we are still missing this part on top of coinbase_payload

https://github.com/dashpay/dips/blob/master/dip-0004.md

Example

"extraPayloadSize": 38,
"extraPayload": "01003e041000ba1019b155a59a8d9f85df3c780415eaaa0f69d8df8ef77497f642dd60d7d2e9",
"cbTx": {
"version": 1,
"height": 1049662,
"merkleRootMNList": "e9d2d760dd42f69774f78edfd8690faaea1504783cdf859f8d9aa555b11910ba"
},

[UdjinM6]

@pinpins cbTx is just a JSON representation of coinbase_payload in RPC.

[crackfoo]

With these changes, blocks aren't being generated (testnet)... 10:13:29: ERROR Dash Block decode failed 10:13:29: *** REJECTED :( Dash block 76117 34 txs

…

On Sun, Apr 7, 2019 at 9:49 AM UdjinM6 ***@***.***> wrote: @pinpins <https://github.com/pinpins> cbTx is just a JSON representation of coinbase_payload in RPC. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#335 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGAv4mQHaeIiEWAnjN11_L2y5gcltle3ks5veelPgaJpZM4aUIIV> .

[pinpins]

@pinpins cbTx is just a JSON representation of coinbase_payload in RPC.

@UdjinM6
Yes, this is what I though it should be, but as blocks got rejected, thought, something more is missing. Thanks for confirmation on this part.

But then there is still something else wrong putting coinbase transaction altogether

[pinpins]

I think found issue with your last commit

		if(coinbase_payload && strlen(coinbase_payload) > 0) {
			char coinbase_payload_size[18];
			ser_compactsize((unsigned int)(strlen(coinbase_payload_size) >> 1), coinbase_payload_size);
			strcat(templ->coinb2, coinbase_payload_size);
			strcat(templ->coinb2, coinbase_payload);				strcat(templ->coinb2, coinbase_payload);
		}

Must be

		if(coinbase_payload && strlen(coinbase_payload) > 0) {
			char coinbase_payload_size[18];
			ser_compactsize((unsigned int)(strlen(coinbase_payload) >> 1), coinbase_payload_size);
			strcat(templ->coinb2, coinbase_payload_size);
			strcat(templ->coinb2, coinbase_payload);				strcat(templ->coinb2, coinbase_payload);
		}

[UdjinM6]

Thanks @pinpins ! 👍

[crackfoo]

testnet works with that fix.

Thanks @pinpins