Skip to content

Commit

Permalink
Add test to make sure ivar = NA FDR works correctly
Browse files Browse the repository at this point in the history
  • Loading branch information
tpq committed Apr 15, 2020
1 parent b85112e commit 30fe458
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 1 deletion.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: propr
Title: Calculating Proportionality Between Vectors of Compositional Data
Version: 4.2.7
Version: 4.2.8
URL: http://github.com/tpq/propr
BugReports: http://github.com/tpq/propr/issues
Authors@R: c(
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## propr 4.2.8
---------------------
* Add `updateCutoffs` warning for asymmetric phi FDR call

## propr 4.2.7
---------------------
* Allow user to skip log-ratio transformation with `ivar = NA`
Expand Down
10 changes: 10 additions & 0 deletions R/2-proprCall.R
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,16 @@ updateCutoffs.propr <- function(object, cutoff, ncores){
})
}

if(object@metric == "rho"){

message("Alert: Estimating FDR for largely positive proportional pairs only.")
}

if(object@metric == "phi"){

warning("We recommend using the symmetric phi 'phs' for FDR permutation.")
}

if(identical(object@permutes, list(NULL))) stop("Permutation testing is disabled.")

# Let NA cutoff skip function
Expand Down

0 comments on commit 30fe458

Please sign in to comment.