fix ci - pin pip #247
Merged
fix ci - pin pip #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamcroberts
force-pushed
the
trigger-test
branch
from
a1d7e7d to
a996aaa
Compare
williamcroberts
force-pushed
the
trigger-test
branch
from
756d18e to
66a208f
Compare
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
=======================================
Coverage 94.01% 94.02%
=======================================
Files 14 14
Lines 4297 4299 +2
Branches 375 377 +2
=======================================
+ Hits 4040 4042 +2
Misses 191 191
Partials 66 66
Continue to review full report at Codecov.
|
williamcroberts
force-pushed
the
trigger-test
branch
from
1d796a6 to
5fc0e10
Compare
added 3 commits
October 22, 2021 13:42
Fixes this error when using a non-editable install. Signed-off-by: William Roberts <[email protected]>
There is a bug in pip version 21.3: - pypa/pip#10573 Thus pin to version 21.2.4 until version 21.3.1 comes out containing commit: - pypa/pip@4a4b613 Signed-off-by: William Roberts <[email protected]>
Test for Fix ModuleNotFoundError: No module named '_libtpm2_pytss' Signed-off-by: William Roberts <[email protected]>
williamcroberts
force-pushed
the
trigger-test
branch
from
5fc0e10 to
8ee92d5
Compare
williamcroberts
pushed a commit
to williamcroberts/tpm2-pytss
that referenced
this pull request
Oct 28, 2021
As documented in: - tpm2-software#247 pip 21.3 was broken with in-place (-e) installs and was fixed in pip 21.3.1. However, the CI is still stuck on pip 21.3 and thus is broken. When patch 57428, which pins pip to a version lower than 21.3 was reverted, we need something to get us after 21.3, so update pip. Signed-off-by: William Roberts <[email protected]>
williamcroberts
pushed a commit
to williamcroberts/tpm2-pytss
that referenced
this pull request
Oct 28, 2021
As documented in: - tpm2-software#247 pip 21.3 was broken with in-place (-e) installs and was fixed in pip 21.3.1. However, the CI is still stuck on pip 21.3 and thus is broken. When patch 57428, which pins pip to a version lower than 21.3 was reverted, we need something to get us after 21.3, so update pip. Signed-off-by: William Roberts <[email protected]>
williamcroberts
pushed a commit
that referenced
this pull request
Oct 28, 2021
As documented in: - #247 pip 21.3 was broken with in-place (-e) installs and was fixed in pip 21.3.1. However, the CI is still stuck on pip 21.3 and thus is broken. When patch 57428, which pins pip to a version lower than 21.3 was reverted, we need something to get us after 21.3, so update pip. Signed-off-by: William Roberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci: pin to pip version 21.2.4
There is a bug in pip version 21.3:
No module named piperror pypa/pip#10573Thus pin to version 21.2.4 until version 21.3.1 comes out containing
commit:
Also add import _cff_backend so that non-editable installed builds work.