Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select-apps: selected games not visible, layout does not match documentation #176

Closed
FreelancerJay opened this issue Oct 14, 2022 · 12 comments
Labels
bug Something isn't working

Comments

@FreelancerJay
Copy link

Hi, first of all love your pre-filler. In terms of function, totally nailing it. Thank you for making it, and sharing it!

Just updated to 1.6.0, and unfortunately the new Select-Apps interface is botched for me.

  • As you scroll through entries, the highlighted one is not visible
  • Selected entries are not visible
  • Most of the UI seems to be greyed out. I'm basing that on comparing what I see on my console to what is in the documentation

The environment is a Debian 11 LXC, running alongside my LanCache itself, and is accessed via lxc-attach. The terminal is xtermjs

Let me know what else would be useful to know to debug!

Screen Shot 2022-10-14 at 2 20 48 pm

@tpill90
Copy link
Owner

tpill90 commented Oct 15, 2022

Hi @FreelancerJay,

I would like to know what the output of echo $TERM gives you from your terminal. I believe the issue here is being caused due to the Tui library I am using requiring the terminal to have support for 256 color pallette : export TERM=xterm-256color.

@FreelancerJay
Copy link
Author

I would like to know what the output of echo $TERM gives you from your terminal. I believe the issue here is being caused due to the Tui library I am using requiring the terminal to have support for 256 color pallette : export TERM=xterm-256color.

Well the output for me is linux, which is... unhelpful. But did get me thinking. I ran tput colors and it reports I've got 8 supported.

So I'll work on getting it set for 256 support.

Perhaps it would be worth running a check when running to see how many colours are supported. The old UI worked fine for me visually, so maybe a switch checking that the terminal is supporting enough colours which falls back to the old UI if it's below 256? Or if you're wanting to dump the old UI, then just a message saying "you need moar colorz" to redirect others in the future :-)

Thanks for taking a look!

@tpill90
Copy link
Owner

tpill90 commented Oct 16, 2022

I think that a combination of the two sounds like the correct solution. I don't necessarily want to support both of them, but at the same time I don't want to require users to have to do some manual configuration to use my app. So maybe in the case that their terminal doesn't have full color support, there is a message warning them how to fix it, and then falls back to the original UI

@tpill90 tpill90 added the bug Something isn't working label Oct 17, 2022
@irishj
Copy link

irishj commented Oct 25, 2022

Seeing the same issue within the terminal of a lancache docker container, run from Portainer.

Output of echo $TERM is xterm
Output of tput colors is 8

Solved the issue by using the 'custom command' option and entering env TERM=xterm-256color /bin/bash. Just in case anyone else runs into the same issue. Thanks for a great tool !

@tpill90
Copy link
Owner

tpill90 commented Oct 28, 2022

This issue seems to be related to this gui-cs/Terminal.Gui#2085

@tpill90
Copy link
Owner

tpill90 commented Oct 28, 2022

I believe I've found a fix, and I've tested it against the following :

Putty

image

Debian 11

image

Windows Terminal

image

@tpill90
Copy link
Owner

tpill90 commented Oct 28, 2022

@FreelancerJay Could you give this test build a shot?
https://github.com/tpill90/steam-lancache-prefill/actions/runs/3348717144

@FreelancerJay
Copy link
Author

Fist thing when I’m hope from work, will test and report back

@FreelancerJay
Copy link
Author

@tpill90, worked like a charm, didn't need to modify $TERM to run that and could still see everything fine!

@tpill90
Copy link
Owner

tpill90 commented Oct 30, 2022

Fantastic! I'll get this merged and included in the next release

@tpill90 tpill90 added the pending release Fix has been merged, needs to be published label Oct 31, 2022
@tpill90 tpill90 removed the pending release Fix has been merged, needs to be published label Oct 31, 2022
@tpill90 tpill90 closed this as completed Oct 31, 2022
@tpill90 tpill90 reopened this Nov 6, 2022
@LilTrublMakr
Copy link

Unfortunately, still having a problem with this on 1.7.3. I have tried MobaXTerm, PuTTY, and Unraids terminal.

https://cdn.discordapp.com/attachments/999228019883380746/1038626584644571176/Screenshot_2022-11-05_213057.png

@tpill90
Copy link
Owner

tpill90 commented Jan 18, 2023

Closing this as I haven't received enough information to reproduce the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants