Merge pull request #374 from /issues/373-Benchmark0mbits

tpill90 · Aug 3, 2024 · 05603ed · 05603ed
2 parents 77bec93 + b80ce52
commit 05603ed
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/SteamPrefill/CliCommands/Benchmark/BenchmarkModels.cs b/SteamPrefill/CliCommands/Benchmark/BenchmarkModels.cs
@@ -15,9 +15,18 @@ public sealed class BenchmarkWorkload
 
         public List<QueuedRequest> AllQueuedRequests => QueuedAppsList.SelectMany(e => e.QueuedRequests).ToList();
 
-        private ByteSize _totalDownloadSize;
-        public ByteSize TotalDownloadSize => _totalDownloadSize;
-        public string TotalDownloadSizeFormatted => _totalDownloadSize.ToDecimalString();
+        private ByteSize? _totalDownloadSize;
+        public ByteSize TotalDownloadSize
+        {
+            get
+            {
+                if (_totalDownloadSize == null)
+                {
+                    _totalDownloadSize = ByteSize.FromBytes(QueuedAppsList.Sum(e => e.TotalBytes));
+                }
+                return _totalDownloadSize.Value;
+            }
+        }
 
         public long TotalFiles => QueuedAppsList.Sum(e => e.FileCount);
         public string TotalFilesFormatted => TotalFiles.ToString("n0");

diff --git a/SteamPrefill/SteamManager.cs b/SteamPrefill/SteamManager.cs
@@ -289,9 +289,10 @@ private static void CheckBenchmarkWorkloadSize(BenchmarkWorkload generatedWorklo
             table.AddColumn("");
 
             // Adding message rows
+            var totalDownloadSize = generatedWorkload.TotalDownloadSize;
             table.AddRow(LightYellow($"{new string(' ', 40)}!!!!!! Warning !!!!!!"));
             table.AddEmptyRow();
-            table.AddRow($"The generated workload size of {Magenta(generatedWorkload.TotalDownloadSizeFormatted)} " +
+            table.AddRow($"The generated workload size of {Magenta(totalDownloadSize.ToBinaryString())} " +
                          $"is smaller than the total system memory of {LightYellow(systemMemory.ToDecimalString())}.");
             table.AddRow("Linux will cache files that it reads in system memory to improve performance of frequently used files,");
             table.AddRow("however this benchmark is typically used to test disk IO performance.");