Update scalar.jl to use muladd #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The errors seems to be from |
|
ptiede#1 should fix CI. |
use LogDensityProblemsAD
|
Sorry, it was closed accidentally. |
tpapp
requested changes
Dec 23, 2022
tpapp
approved these changes
Jan 9, 2023
|
Sorry for the delay! Holidays happened, and I got stuck with a recent Enzyme bug that just got fixed. Did you want me to add an additional test in another PR? |
|
It is fine as it is, but of course tests are always welcome if you have time. Thanks again for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates scalar.jl to use muladd generically for
ScaledShiftedLogisticsince JuliaDiff/DiffRules.jl#28 has been merged. I also usedmuladdinstead offmasince it only usesfmaif it does give a speed boost. Additionally, I was having issues using Enzyme.jl with fma inserted while everything seems to work fine with muladd.