-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only respect ALL environments when not in parallel #2207
Only respect ALL environments when not in parallel #2207
Conversation
As
this is kind of a draft/request PR. I will happily create appropriate changelog when you tell me, this is a sensible way of fixing the problem. Thanks for the awesome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add changelog and test for this?
I added the changelog. Unfortunately I do not have the time to write a test right now (as I would have to dig deep into this to understand how to even test this behavior of the subprocess invocation). I would be happy, if anybody can assist with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs a test, check around the test suite to find instances of this.
I had a look into it and it wasn't that hard indeed. |
fixes #2167
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rst
for example (588.bugfix.rst)<type>
is must be one ofbugfix
,feature
,deprecation
,breaking
,doc
,misc
-- by :user:`<your username>`.
CONTRIBUTORS
(preserving alphabetical order)