Have --license work with --reverse #321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #318 I did not consider the case where users would pass --reverse along with --license. Currently, doing so would have us output the following:
As it's shown, the required packages (i.e. graph nodes that were instances of
DistPackage
) are given their license when the top-level packages should have been given theirs instead. This PR addresses this text render issue by appending the license to a package only if it's a top-level package (instead of just checking to see ifnode
is an instance ofDistPackage
).The output with my changes: