models/package: have version_spec only exist in ReqPackage
#303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This behavior is specific to `ReqPackage`, so let's just have it exist in this class rather than having it in the `Package` parent class.
|
Recent change includes 2 test cases to satisfy code coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior is specific to
ReqPackage, so let's just have it exist in this class rather than having it in thePackageparent class.Just to be extra careful, I ran the rendering options that may be affected by this change (so graphviz, mermaid, and json tree) in both reversed and non-reversed order to cover the code paths that use
version_spec. Everything looks fine from what I can see.