Detect dependency cycles beyond a depth = 2 #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Signed-off-by: Bernát Gábor <[email protected]>
gaborbernat
approved these changes
Jul 30, 2023
jankatins
referenced
this pull request
in jankatins/pr-workflow-example
Jul 30, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pipdeptree](https://togithub.com/tox-dev/pipdeptree) ([changelog](https://togithub.com/tox-dev/pipdeptree/blob/main/CHANGES.md)) | `2.11.0` -> `2.12.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>tox-dev/pipdeptree (pipdeptree)</summary> ### [`v2.12.0`](https://togithub.com/tox-dev/pipdeptree/releases/tag/2.12.0) [Compare Source](https://togithub.com/tox-dev/pipdeptree/compare/2.11.0...2.12.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed - Detect dependency cycles beyond a depth = 2 by [@​kemzeb](https://togithub.com/kemzeb) in [https://github.com/tox-dev/pipdeptree/pull/274](https://togithub.com/tox-dev/pipdeptree/pull/274) **Full Changelog**: tox-dev/pipdeptree@2.11.0...2.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jankatins/pr-workflow-example). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuMjQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #191.
The previous implementation of
cyclic_deps()only detected a dependency cycle when a dependency of aDistPackagewas dependent on thatDistPackage(e.g. a -> b -> a). Sadly, this did not bid well when you have a cycle such as a -> b -> c -> d -> e -> a (i.e. it has a depth > 2 with "a" as the root).This CL reimplements it to use DFS, where we perform DFS on each
DistPackageand just check to see if thisDistPackage(think of it as the root node) was revisited (by comparing the current node's key that were are visiting to the root node's key).