Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify loops #267

Merged
merged 3 commits into from
Jul 15, 2023
Merged

Simplify loops #267

merged 3 commits into from
Jul 15, 2023

Conversation

eumiro
Copy link
Member

@eumiro eumiro commented Jul 15, 2023

(the previous PR got closed because I accidentally deleted the branch)

@eumiro eumiro marked this pull request as draft July 15, 2023 15:59
@eumiro
Copy link
Member Author

eumiro commented Jul 15, 2023

The mermaid_id method always returns a str, so there's no need to return something else at the end, but the checks fail. What would you like to return there? A non-existent str or flag the method to be skipped by the test?

@eumiro eumiro marked this pull request as ready for review July 15, 2023 16:09
@gaborbernat
PR Feedback
380890c 
Signed-off-by: Bernát Gábor <[email protected]>
@gaborbernat gaborbernat merged commit e861826 into tox-dev:main Jul 15, 2023
@eumiro eumiro deleted the loops branch July 15, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eumiro @gaborbernat