Avoid changing t in randomized_dag_copy() by shallow copying
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`randomized_dag_copy()` ends up modifying the global variable `t` when it shuffles the required package list associated to a `DistPackage`. This CL fixes this by just shallow copying the list.
kemzeb
changed the title
t in randomized_dag_copy() by shadow copyingt in randomized_dag_copy() by shallow copying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #256.
After doing some bisecting and running the testing code using the
randomlyplugin, I found that the problem lies here:pipdeptree/tests/test_pipdeptree.py
Line 775 in f18a321
randomized_dag_copy()ends up modifying the global variabletwhen it shuffles the list ofReqPackages associated to aDistPackage.This CL fixes this by just shallow copying the list.