Add ability to return immediately when a lock cannot be obtained inst… #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a typo in |
FFY00
reviewed
May 3, 2022
There was a problem hiding this comment.
Wouldn't blocking/nonblocking be a more standard name?
Eg. https://docs.python.org/3/library/threading.html#threading.Lock.acquire
…dard name blocking
|
I chose return_immediately because it was suggested in the original issue, but I agree blocking/nonblocking is the more standard convention. I updated the PR to change to blocking. |
|
There is one flake 8 issue. |
gaborbernat
requested changes
May 8, 2022
|
You'll need to fix the CI 👍 |
gaborbernat
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #57