balance: Internally represent weights as integers #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The balancer's `Weight` type represents a weight value as a float because, conceptually, we want to think of a unit weight of 1.0... However, storing a float means that this type cannot be hashed, and therefore all types that hold a Weight cannot implement Hash. Given that `Balance` expects that keys impl `Hash` and `Eq`, this is especially cumbersome. This branch changes the internal representation of weights to be unsigned integers with a unit value of `10_000` (corresponding to 1.0000).
|
superseded by #286 |
samvrlewis
added a commit
to samvrlewis/tower
that referenced
this pull request
Sep 30, 2022
Adds a `weight` load variant, which weights an inner load. This is useful in circumstances where it is desireable to artificially inflate or deflate load. One such example is canary deployments, where it might be preferable for a canary to accept less load than its non-canary counterparts. This change is adapted from the weight implementation that used to exist within tower but was removed [^1] and an associated unmerged PR [^2]. [^1] See tower-rs@a496fbf [^2] See tower-rs#282
samvrlewis
added a commit
to samvrlewis/tower
that referenced
this pull request
Sep 30, 2022
Adds a `weight` load variant, which weights an inner load. This is useful in circumstances where it is desireable to artificially inflate or deflate load. One such example is canary deployments, where it might be preferable for a canary to accept less load than its non-canary counterparts. This change is adapted from the weight implementation that used to exist within tower but was removed (see #a496fbf72c) and an associated unmerged PR (tower-rs#282).
samvrlewis
added a commit
to samvrlewis/tower
that referenced
this pull request
Sep 30, 2022
Adds a `weight` load variant, which weights an inner load. This is useful in circumstances where it is desireable to artificially inflate or deflate load. One such example is canary deployments, where it might be preferable for a canary to accept less load than its non-canary counterparts. This change is adapted from the weight implementation that used to exist within tower but was removed (see tower-rs/tower@a496fbf) and an associated unmerged PR (tower-rs#282).
samvrlewis
added a commit
to samvrlewis/tower
that referenced
this pull request
Sep 30, 2022
Adds a `weight` load variant, which weights an inner load. This is useful in circumstances where it is desireable to artificially inflate or deflate load. One such example is canary deployments, where it might be preferable for a canary to accept less load than its non-canary counterparts. This change is adapted from the weight implementation that used to exist within tower but was removed (see tower-rs/tower@a496fbf) and an associated unmerged PR (tower-rs#282).
samvrlewis
added a commit
to samvrlewis/tower
that referenced
this pull request
Sep 30, 2022
Adds a `weight` load variant, which weights an inner load. This is useful in circumstances where it is desireable to artificially inflate or deflate load. One such example is canary deployments, where it might be preferable for a canary to accept less load than its non-canary counterparts. This change is adapted from the weight implementation that used to exist within tower but was removed (see tower-rs/tower@a496fbf) and an associated unmerged PR (tower-rs#282).
samvrlewis
added a commit
to samvrlewis/tower
that referenced
this pull request
Oct 4, 2022
Adds a `weight` load variant, which weights an inner load. This is useful in circumstances where it is desireable to artificially inflate or deflate load. One such example is canary deployments, where it might be preferable for a canary to accept less load than its non-canary counterparts. This change is adapted from the weight implementation that used to exist within tower but was removed (see tower-rs/tower@a496fbf) and an associated unmerged PR (tower-rs#282).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The balancer's
Weighttype represents a weight value as a floatbecause, conceptually, we want to think of a unit weight of 1.0...
However, storing a float means that this type cannot be hashed, and
therefore all types that hold a Weight cannot implement Hash. Given that
Balanceexpects that keys implHashandEq, this is especiallycumbersome.
This branch changes the internal representation of weights to be
unsigned integers with a unit value of
10_000(corresponding to1.0000).