Http range headers 0.4 #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Jul 21, 2023
jplatte
reviewed
Jul 21, 2023
| @@ -496,11 +496,16 @@ async fn read_partial_rejects_out_of_bounds_range() { | |||
| .unwrap(); | |||
| let res = svc.oneshot(req).await.unwrap(); | |||
|
|
|||
| assert_eq!(res.status(), StatusCode::RANGE_NOT_SATISFIABLE); | |||
| assert_eq!(res.status(), StatusCode::PARTIAL_CONTENT); | |||
There was a problem hiding this comment.
So if all bytes get returned, does it still make sense for the status code to be 'partial content'?
There was a problem hiding this comment.
I did actualy consider that and if I understand the spec correctly, it does https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/206
The HTTP 206 Partial Content success status response code indicates that the request has succeeded and the body contains the requested ranges of data, as described in the Range header of the request.
Granted, it is kind of strange
jplatte
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #384
Solution
Updates http-range-header to
0.4, it broke a test rejecting a spec-valid header so that's fixed here as well.Added a bunch of tests in
0.4re-ran the fuzzing and made a few optimizations. I think the performance increase was something like 15% across the board. Set the msrv on that project to the same as this one, 1.60.0. Added msrv to thepackage.metadatafortower-http, so I could runcargo msrv verifyon it, it checks out.The actual fix came from @jfaust in this PR MarcusGrass/http-range-header#3