Preserve service error type in RequestDecompression #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
added
C-cleanup
davidpdrsn
approved these changes
Nov 20, 2023
psFried
added a commit
to estuary/connectors
that referenced
this pull request
Feb 22, 2024
Axum and tower-http had a few minor breaking changes. Tower-http [improved error handling of RequestDecompressionLayer](tower-rs/tower-http#368), which allowed removal of some annoying error conversion code.
psFried
added a commit
to estuary/connectors
that referenced
this pull request
Feb 22, 2024
Axum and tower-http had a few minor breaking changes. Tower-http [improved error handling of RequestDecompressionLayer](tower-rs/tower-http#368), which allowed removal of some annoying error conversion code.
jonwihl
pushed a commit
to estuary/connectors
that referenced
this pull request
Mar 13, 2024
Axum and tower-http had a few minor breaking changes. Tower-http [improved error handling of RequestDecompressionLayer](tower-rs/tower-http#368), which allowed removal of some annoying error conversion code.
jonwihl
pushed a commit
to estuary/connectors
that referenced
this pull request
Mar 18, 2024
Axum and tower-http had a few minor breaking changes. Tower-http [improved error handling of RequestDecompressionLayer](tower-rs/tower-http#368), which allowed removal of some annoying error conversion code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be no reason for
RequestDecompressionto change the service error type toBoxError, so it would be nice to preserve the underlying error type. This is especially useful if the inner service is infallible.Motivation
When I add
RequestDecompressionLayerto a stack of infallible layers, the resulting service hasBoxErroras an error type, but it never actually fails.Solution
Make
RequestDecompressionpreserve the error type of the inner service.