Skip to content

Commit

Permalink
Remove ScaleDownNodeDeleted status since we no longer delete nodes sy…
Browse files Browse the repository at this point in the history
…nchronously

Fixes kubernetes#3568
  • Loading branch information
towca committed Oct 1, 2020
1 parent 7a264f5 commit 242917c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion cluster-autoscaler/core/static_autoscaler.go
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ func (a *StaticAutoscaler) RunOnce(currentTime time.Time) errors.AutoscalerError

scaleDownStatus.RemovedNodeGroups = removedNodeGroups

if scaleDownStatus.Result == status.ScaleDownNodeDeleted {
if scaleDownStatus.Result == status.ScaleDownNodeDeleteStarted {
a.lastScaleDownDeleteTime = currentTime
a.clusterStateRegistry.Recalculate()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,6 @@ const (
ScaleDownNoUnneeded
// ScaleDownNoNodeDeleted - unneeded nodes present but not available for deletion.
ScaleDownNoNodeDeleted
// ScaleDownNodeDeleted - a node was deleted.
ScaleDownNodeDeleted
// ScaleDownNodeDeleteStarted - a node deletion process was started.
ScaleDownNodeDeleteStarted
// ScaleDownNotTried - the scale down wasn't even attempted, e.g. an autoscaling iteration was skipped, or
Expand Down

0 comments on commit 242917c

Please sign in to comment.