-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution by Marco Yue #5
Open
yuekalong
wants to merge
23
commits into
toursbylocals:main
Choose a base branch
from
yuekalong:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refine the animations
…t current version of jest is bugged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello I am Marco.
Here is my solution for the Candidate Assessment Test.
To start the project:
Project Includes:
Libraries I have used
And images are from PNGTree and Unsplash.
Something I would like to improve
Implement Page Transitions:
Add smooth transitions between pages to enhance user experience (UX) across the project.
Enhance SEO:
Optimize the HTML tags used throughout the site and incorporate relevant meta tags for each individual page to improve search engine visibility.
Organize Components:
Structure the page components systematically and utilize Storybook for testing and documentation to ensure consistency.
Expand Testing Coverage:
Develop additional test scripts to verify that all features of the project function correctly and efficiently, ensuring a smooth user experience.