(dev/core#5365) Update civimix-schema #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manually tried making an extension on 5.63.3 and 5.78.4 -- with a schema upgrader. Seemed to fix it. QA procedure: ## Setup - Before this PR
civix generate:module hello
cd hello
civix generate:upgrader
vi CRM/Hello/Upgrader.php ## define a new step
## In web UI, check to see if there's a web-alert.
## ==> With old code, the web-alert is missing.
## Then apply this PR and run `civix upgrade`, the
## ==> With new code, the web-alert is provided. |
totten
force-pushed
the
master-civimix
branch
from
f6145f3 to
8c8647f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport civicrm/civicrm-core#30740 and other recent changes to civimix-schema. Fixes https://lab.civicrm.org/dev/core/-/issues/5642, https://lab.civicrm.org/dev/core/-/issues/5365
Before
When you have a custom upgrader (
CRM/Foo/Upgrader.php) with a pending task...cv updb), it works.After
It will be both display the notification and also run the upgrade.