Paths - On Windows, normalize to forward-slash #368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by loren-bm on (Mattermost), there's a recent regression when running
civix upgrade
on Windows:The underlying problem involves the switch to
Webmozart\Glob
-- @demeritcowboy found that it expects to have paths normalized using/
. This is not entirely unusual. Symfony Filesystem v5.4+ has a similar normalization policy.This revision should fix the error. The patch is a little more aggressive, in that it flip-flips on the whole approach to normalizing paths:
Path
helper tries to use nativeDIRECTORY_SEPARATOR
. But it doesn't try very hard. So in practice, you probably a get a mix of delimiters.Path
helper tries to consistently use/
on both Windows and Unix.I've posted an example build of
civix.phar
at:https://ephemera.civicrm.org/civix/civix.phar-2024-09-25-windows