Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references from extension aliases to the CRM_Core_Extension #366

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

eileenmcnaughton
Copy link
Contributor

Prior to CiviCRM 5.52 we threw a mismash of these extensions. They all had to work everywhere because it was unpredictable. In 5.52 we made the API_Exception and CiviCRM_Api3_Exception aliases of CRM_Core_Exception. However, on the off chance people are creating extensions for really old civi versions with the latest civix it would still be handled on those older versions (we were always throwing CRM_Core_Exception all over the show)

Prior to CiviCRM 5.52 we threw a mismash of these extensions. They all had to work everywhere because it
was unpredictable. In 5.52 we made the API_Exception and CiviCRM_Api3_Exception aliases of
CRM_Core_Exception. However, on the off chance people are creating extensions for really old civi
versions with the latest civix it would still be handled on those older versions (we were
always throwing CRM_Core_Exception all over the show)
@totten
Copy link
Owner

totten commented Sep 19, 2024

Yeah, I think this works. 👍

The templates affected here are like demonstrative code (some soft @throws and some illustrations of "how you might use an exception") rather than "central glue affecting all handling of exception". Even if there are some existing extensions/historical versions which treat API_Exception and CRM_Core_Exception differently... it doesn't really affect the quality of the demonstration.

@totten totten merged commit 3635a55 into totten:master Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants