tests/e2e - Isolate each call to civix. More representative of real usage #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an off-shoot of work on #331. Here's the main comment that explains the purpose.
Ah, blerg. There's a test-interaction problem (i.e. tests pass individually but fail in bulk). E2E tests look like this:
function xyz() {...}
stays in memory.)*.civix.php
. Steps aren't just additive -- they can change the content of*.civix.php
. (This PR is a good example.)--process-isolation
puts each test-case in its own process. But it's not quite realistic -- individual steps would still share the same process.CivixProjectTestTrait::civix()
calls Symfony'sCommandTester
. Swap that with something similar that uses sub-processes. This could reveal some other hidden interactions, but it's probably better in the long run.So this PR implements the second approach.