Fix various warnings on PHP 8.2 / PHPUnit 9 #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated: Creation of dynamic property CRM\CivixBundle\Builder\Module::$templateEngine is deprecated in /home/totten/src/civix/src/CRM/CivixBundle/Builder/Module.php on line 11
Deprecated: Creation of dynamic property CRM\CivixBundle\Builder\Collection::$builders is deprecated in /home/totten/src/civix/src/CRM/CivixBundle/Builder/Collection.php on line 12
Creation of dynamic property CRM\CivixBundle\Builder\License::$license is deprecated
When running the full suite on the command-line, these tests hang because they mistakenly execute subcommands with interactive mode. They proceed if you press "Enter", but that's silly.
totten
changed the title
Closed
|
This is passing in most permutations. The remaining failures are probably a consequence of incompatibilities between [email protected] and [email protected]. It's annoying to show formally. But I think this is better in than out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.