generate:form gives PHP Fatal error: Uncaught TypeError: Return value of "CRM\CivixBundle\Command\AddFormCommand::execute()" must be of the type int, "null" returned. in ...\vendor\symfony\console\Command\Command.php:301

src/CRM/CivixBundle/Command/AbstractAddPageCommand.php

@@ -92,6 +92,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $mixins = new Mixins($info, $basedir->string('mixin'), ['[email protected]', '[email protected]']);
     $mixins->save($ctx, $output);
     $info->save($ctx, $output);
+    return 0;
   }
 
   abstract protected function getPhpTemplate(InputInterface $input);

src/CRM/CivixBundle/Command/AddAngularDirectiveCommand.php

@@ -46,7 +46,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $attrs = $info->get()->attributes();
     if ($attrs['type'] != 'module') {
       $output->writeln('<error>Wrong extension type: ' . $attrs['type'] . '</error>');
-      return;
+      return 1;
     }
 
     $ctx['tsDomain'] = (string) $attrs['key'];
@@ -80,6 +80,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 
     $ext->init($ctx);
     $ext->save($ctx, $output);
+    return 0;
   }
 
   public function toHyphen($dirName) {

src/CRM/CivixBundle/Command/AddAngularModuleCommand.php

@@ -77,6 +77,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 
     $ext->loadInit($ctx);
     $ext->save($ctx, $output);
+    return 0;
   }
 
 }

src/CRM/CivixBundle/Command/AddAngularPageCommand.php

@@ -51,7 +51,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $attrs = $info->get()->attributes();
     if ($attrs['type'] != 'module') {
       $output->writeln('<error>Wrong extension type: ' . $attrs['type'] . '</error>');
-      return;
+      return 1;
     }
 
     $ctx['tsDomain'] = (string) $attrs['key'];
@@ -81,6 +81,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 
     $ext->init($ctx);
     $ext->save($ctx, $output);
+    return 0;
   }
 
 }

src/CRM/CivixBundle/Command/AddApiCommand.php

@@ -160,6 +160,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $phpUnitInitFiles->initPhpunitBootstrap($basedir->string('tests', 'phpunit', 'bootstrap.php'), $ctx, $output);
 
     $info->save($ctx, $output);
+    return 0;
   }
 
 }

src/CRM/CivixBundle/Command/AddCaseTypeCommand.php

@@ -27,7 +27,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $civicrm_api3 = Services::api3();
     if (!$civicrm_api3 || !$civicrm_api3->local) {
       $output->writeln("Requires access to local CiviCRM source tree. Configure civicrm_api3_conf_path.</error>");
-      return;
+      return 1;
     }
 
     $this->assertCurrentFormat();
@@ -59,6 +59,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $mixins = new Mixins($info, $basedir->string('mixin'), ['[email protected]']);
     $mixins->save($ctx, $output);
     $info->save($ctx, $output);
+    return 0;
   }
 
 }

src/CRM/CivixBundle/Command/AddCustomDataCommand.php

@@ -45,7 +45,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $attrs = $info->get()->attributes();
     if ($attrs['type'] != 'module') {
       $output->writeln('<error>Wrong extension type: ' . $attrs['type'] . '</error>');
-      return;
+      return 1;
     }
 
     $dirs = new Dirs([
@@ -77,6 +77,8 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     else {
       $output->writeln(" * NOTE: By default, this file will not be loaded automatically -- you must define installation or upgrade logic to load the file.");
     }
+
+    return 0;
   }
 
 }

src/CRM/CivixBundle/Command/AddEntityBoilerplateCommand.php

@@ -148,6 +148,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
       $output->writeln('<comment>You are missing an upgrader class. Your generated SQL files will not be executed on enable and uninstall. Fix this by running `civix generate:upgrader`.</comment>');
     }
 
+    return 0;
   }
 
   private function orderTables(&$tables, $output) {

src/CRM/CivixBundle/Command/AddEntityCommand.php

@@ -46,7 +46,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $civicrm_api3 = Services::api3();
     if (!$civicrm_api3 || !$civicrm_api3->local) {
       $output->writeln("<error>Require access to local CiviCRM source tree. Configure civicrm_api3_conf_path.</error>");
-      return;
+      return 1;
     }
 
     $this->assertCurrentFormat();
@@ -152,6 +152,8 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 
     $output->writeln('<comment>You should now make any changes to the entity xml file and run `civix generate:entity-boilerplate` to generate necessary boilerplate.</comment>');
     $output->writeln('<comment>Note: no changes have been made to the database. You can update the database by uninstalling and re-enabling the extension.</comment>');
+
+    return 0;
   }
 
 }

src/CRM/CivixBundle/Command/AddReportCommand.php

@@ -119,6 +119,8 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 
     $ext->loadInit($ctx);
     $ext->save($ctx, $output);
+
+    return 0;
   }
 
   /**

src/CRM/CivixBundle/Command/AddSearchCommand.php

@@ -114,6 +114,8 @@ function ($phpSrc) use ($origTplFile, $ctx) {
 
     $ext->loadInit($ctx);
     $ext->save($ctx, $output);
+
+    return 0;
   }
 
   /**

src/CRM/CivixBundle/Command/AddTestCommand.php

@@ -73,6 +73,8 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $phpUnitInitFiles->initPhpunitBootstrap($basedir->string('tests', 'phpunit', 'bootstrap.php'), $ctx, $output);
     $this->initTestClass(
       $input->getArgument('<CRM_Full_ClassName>'), $this->getTestTemplate($input->getOption('template')), $basedir, $ctx, $output);
+
+    return 0;
   }
 
   protected function getTestTemplate($type) {

src/CRM/CivixBundle/Command/AddThemeCommand.php

@@ -94,6 +94,8 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 
     $ext->loadInit($ctx);
     $ext->save($ctx, $output);
+
+    return 0;
   }
 
 }

src/CRM/CivixBundle/Command/AddUpgraderCommand.php

@@ -32,7 +32,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $attrs = $info->get()->attributes();
     if ($attrs['type'] != 'module') {
       $output->writeln('<error>Wrong extension type: ' . $attrs['type'] . '</error>');
-      return;
+      return 1;
     }
 
     $dirs = [
@@ -63,6 +63,8 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $module = new Module(Services::templating());
     $module->loadInit($ctx);
     $module->save($ctx, $output);
+
+    return 0;
   }
 
 }

src/CRM/CivixBundle/Command/BuildCommand.php

@@ -29,7 +29,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $attrs = $info->get()->attributes();
     if ($attrs['type'] != 'module') {
       $output->writeln('<error>Wrong extension type: ' . $attrs['type'] . '</error>');
-      return;
+      return 1;
     }
 
     $ctx['zipFile'] = $basedir->string('build', $ctx['fullName'] . '.zip');
@@ -54,6 +54,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
       throw new \RuntimeException('Failed to create zip');
     }
     print $process->getOutput();
+    return 0;
   }
 
 }

src/CRM/CivixBundle/Command/ConfigGetCommand.php

@@ -21,6 +21,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     foreach ($this->getInterestingParameters() as $key) {
       printf("%-40s \"%s\"\n", $key, @$config['parameters'][$key]);
     }
+    return 0;
   }
 
   protected function getInterestingParameters() {

src/CRM/CivixBundle/Command/ConfigSetCommand.php

@@ -36,6 +36,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $data['parameters'][$input->getArgument('key')] = $input->getArgument('value');
     $ext->builders['ini']->set($data);
     $ext->save($ctx, $output);
+    return 0;
   }
 
 }

src/CRM/CivixBundle/Command/InfoGetCommand.php

@@ -59,6 +59,8 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     foreach ($info->get()->xpath($xpath) as $node) {
       $output->writeln((string) $node, OutputInterface::OUTPUT_RAW);
     }
+
+    return 0;
   }
 
 }

src/CRM/CivixBundle/Command/InfoSetCommand.php

@@ -60,6 +60,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     }
 
     $info->save($ctx, $output);
+    return 0;
   }
 
 }

src/CRM/CivixBundle/Command/InitCommand.php

@@ -72,7 +72,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     // Name should start with an alpha and only contain alphanumeric, - and .
     if (!Naming::isValidFullName($name)) {
       $output->writeln('<error>Malformed package name</error>');
-      return;
+      return 1;
     }
 
     $ctx['basedir'] = $name;
@@ -88,7 +88,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     else {
       $output->writeln("<error>Missing author name or email address</error>");
       $output->writeln("<error>Please pass --author and --email, or set defaults in ~/.gitconfig</error>");
-      return;
+      return 1;
     }
     $ctx['license'] = $input->getOption('license');
     if ($licenses->get($ctx['license'])) {
@@ -97,7 +97,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     }
     else {
       $output->writeln('<error>Unrecognized license (' . $ctx['license'] . ')</error>');
-      return;
+      return 1;
     }
 
     if ($input->getOption('compatibility') === 'current') {
@@ -156,6 +156,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $ext->save($ctx, $output);
 
     $this->tryEnable($input, $output, $ctx['fullName']);
+    return 0;
   }
 
   /**

src/CRM/CivixBundle/Command/PingCommand.php

@@ -28,6 +28,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     else {
       $output->writeln('<error>Ping failed: API Error: ' . $civicrm_api3->errorMsg() . '</error>');
     }
+    return 0;
   }
 
 }

src/CRM/CivixBundle/Command/TestRunCommand.php

@@ -50,32 +50,32 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $info->load($ctx);
     if ($info->getType() != 'module') {
       $output->writeln('<error>Wrong extension type: ' . $attrs['type'] . '</error>');
-      return;
+      return 1;
     }
 
     // Find the main phpunit
     $civicrm_api3 = Services::api3();
     if (!$civicrm_api3 || !$civicrm_api3->local) {
       $output->writeln("<error>'test' requires access to local CiviCRM source tree. Configure civicrm_api3_conf_path.</error>");
-      return;
+      return 1;
     }
     global $civicrm_root;
     if (empty($civicrm_root) || !is_dir($civicrm_root)) {
       $output->writeln("<error>Failed to locate CiviCRM root path: $civicrm_root</error>");
-      return;
+      return 1;
     }
     $phpunit_bin = "$civicrm_root/tools/scripts/phpunit";
     if (!file_exists($phpunit_bin)) {
       $output->writeln("<error>Failed to locate PHPUnit:\n  $phpunit_bin</error>");
       $output->writeln("<error>Have you configured CiviCRM for testing? See also:\n  https://docs.civicrm.org/dev/en/latest/testing/#setup</error>");
-      return;
+      return 1;
     }
     $test_settings_path = "$civicrm_root/tests/phpunit/CiviTest/civicrm.settings.php";
     $test_settings_dist_path = "$civicrm_root/tests/phpunit/CiviTest/civicrm.settings.dist.php";
     if (!file_exists($test_settings_path) && !file_exists($test_settings_dist_path)) {
       $output->writeln("<error>Failed to locate test settings:\n  $test_settings_path</error>");
       $output->writeln("<error>Have you configured CiviCRM for testing? See also:\n  https://docs.civicrm.org/dev/en/latest/testing/#setup</error>");
-      return;
+      return 1;
     }
     if (file_exists($test_settings_path) && self::checkLegacyExtensionSettings($test_settings_path)) {
       $output->writeln("<comment>Warning: Possible conflicts in $test_settings_path</comment>");
@@ -85,7 +85,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $phpunit_boot = $this->getBootstrapFile($info->getKey(), $input->getOption('clear'));
     if (empty($phpunit_boot) || !file_exists($phpunit_boot)) {
       $output->writeln("<error>Failed to create PHPUnit bootstrap file</error>");
-      return;
+      return 1;
     }
 
     $tests_dir = implode(DIRECTORY_SEPARATOR, [getcwd(), 'tests', 'phpunit']);
@@ -121,6 +121,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
       $output->write($buffer);
     });
     $output->write("\n");
+    return 0;
   }
 
   /**