hook_civicrm_config: Remove &. Simplify __DIR__.
#235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm getting notices about this line ``` $template = & CRM_Core_Smarty::singleton(); ``` PHP Notice: Only variables should be assigned by reference in /srv/civi-sites/wmff/civicrm/ext/greenwich/greenwich.civix.php on line 94 __DIR__ is just a teensy bit shorter / more readable
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jan 26, 2022
Per totten/civix#235 this language construct appears to be getting more noisy about being bad....
|
@totten I don't have merge rights here - can you please merge this |
totten
changed the title
&. Simplify __DIR__.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting notices about this line
PHP Notice: Only variables should be assigned by reference in /srv/civi-sites/wmff/civicrm/ext/greenwich/greenwich.civix.php on line 94
DIR is just a teensy bit shorter / more readable