Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern detector works as a regex #5

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

w-edd
Copy link
Contributor

@w-edd w-edd commented Feb 29, 2024

Technically, main.tf will also match main-tf etc. But the simplicity and readability, as tradeoff, are worth it, imo.

Let me know what you think.

I've added this because in our monorepo different live dirs don't have a common file to match. But a regex pattern, yes.

@marcportabellaclotet-mt
Copy link
Contributor

Thanks @w-edd .
This looks as an interesting improvement.
I agree that using regex adds more flexibility and it suits to other use cases.

@marcportabellaclotet-mt marcportabellaclotet-mt merged commit 699a8a4 into totmicro:main Apr 3, 2024
@w-edd w-edd deleted the pattern-detector-regex branch April 3, 2024 12:31
@marcportabellaclotet-mt
Copy link
Contributor

Just reverted the PR, as it does not work well with multi-workspace discovery mode and regex.
I will work on it, and also a few updates that I have in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants