-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting type errors with Axios #6
Comments
Interesting, I'll do some checking on this. It looks like AxiosInstance is a function? One with multiple overloads. I could see that causing an issue. |
Whoops, didn't mean to close. |
Thanks for looking into it. It's been integral to me removing hundreds of casts! |
mattpocock
added a commit
that referenced
this issue
Jun 14, 2023
mattpocock
added a commit
that referenced
this issue
Jun 14, 2023
…-fixed--6 Refactored tests and fixed #6
Fixed in 0.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
fromPartial
seems to work perfectly for replacing every type-cast in our test suite except when we dofromPartial<AxioInstance>({})
. We're using Axios 0.27.2 and shoehorn 0.10, but it seems to be requiring all the fields of an instance. I can flesh out this ticket tomorrow with the actual error, but I thought I'd ask in case it's something obvious.A Codesandbox showing the TS Error is here: https://codesandbox.io/s/falling-currying-pv8lfk?file=/src/Shoehorn.spec.ts:
The text was updated successfully, but these errors were encountered: