🐛 fix: Handle comparison between null and another object.

total-order · Sep 1, 2020 · fa1589b · fa1589b
1 parent f916a1f
commit fa1589b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/index.js b/src/index.js
@@ -60,6 +60,15 @@ const deepCompare = (a, b) => {
 
 		assert(typeof_a === 'object');
 
+		if (_a === null) {
+			if (_b === null) continue;
+			return -1;
+		}
+
+		if (_b === null) {
+			return 1;
+		}
+
 		if (pendingOrChecked.has([_a, _b])) continue;
 		pendingOrChecked.add([_a, _b]);
 		pendingOrChecked.add([_b, _a]);

diff --git a/test/src/deepCompare.js b/test/src/deepCompare.js
@@ -68,6 +68,7 @@ test(macro, null, undefined, -1);
 test(macro, undefined, null, 1);
 test(macro, undefined, {}, 1);
 test(macro, {}, undefined, -1);
+test(macro, null, {}, -1);
 test(macro, {}, {}, 0);
 test(macro, {}, {a: 1}, -1);
 test(macro, {a: 1}, {}, 1);