Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix unnecessary tournament chat reset #243

Merged
merged 2 commits into from
Nov 22, 2024
Merged

fix: fix unnecessary tournament chat reset #243

merged 2 commits into from
Nov 22, 2024

Conversation

cyperdark
Copy link
Collaborator

No description provided.

@cyperdark cyperdark marked this pull request as draft November 17, 2024 17:16
@cyperdark cyperdark linked an issue Nov 17, 2024 that may be closed by this pull request
[Flaky] In Tournament mode, data.tourney.manager.chat value alternating between empty list and actual chats #239
Closed
@cyperdark cyperdark marked this pull request as ready for review November 20, 2024 00:27
KotRikD
KotRikD requested changes Nov 22, 2024
View reviewed changes
packages/tosu/src/memory/types.ts Outdated Show resolved Hide resolved
packages/tosu/src/memory/stable.ts Outdated Show resolved Hide resolved
packages/tosu/src/states/tourney.ts Outdated Show resolved Hide resolved
@cyperdark cyperdark requested a review from KotRikD November 22, 2024 03:47
@cyperdark cyperdark merged commit 466242c into master Nov 22, 2024
3 checks passed
@cyperdark cyperdark deleted the fix/tournament-chat branch November 22, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KotRikD KotRikD KotRikD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Flaky] In Tournament mode, data.tourney.manager.chat value alternating between empty list and actual chats
2 participants
@cyperdark @KotRikD