Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multiply): Add multiply to compact layer #930

Merged
merged 7 commits into from
Jan 18, 2025

Conversation

aken-you
Copy link
Contributor

@aken-you aken-you commented Jan 9, 2025

스크린샷 2025-01-08 오후 10 42 41

@aken-you aken-you requested a review from raon0211 as a code owner January 9, 2025 05:43
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2025 11:54am

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.90%. Comparing base (32a1838) to head (eebb6c1).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
- Coverage   99.96%   99.90%   -0.07%     
==========================================
  Files         362      363       +1     
  Lines        3087     3102      +15     
  Branches      909      916       +7     
==========================================
+ Hits         3086     3099      +13     
- Misses          1        2       +1     
- Partials        0        1       +1     

@raon0211
Copy link
Collaborator

There were some logic which lodash handled, so I added some code and tests.

raon0211
raon0211 previously approved these changes Jan 18, 2025
Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raon0211 raon0211 merged commit 14843ee into toss:main Jan 18, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants