fix(flattenObject): flatten for nested objects #817
Merged
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nnnnoel
commented
Nov 13, 2024
src/object/flattenObject.ts
Outdated
| @@ -46,7 +46,12 @@ function flattenObjectImpl(object: object, prefix = ''): Record<string, any> { | |||
|
|
|||
| if (Array.isArray(value)) { | |||
| for (let index = 0; index < value.length; index++) { | |||
| result[`${prefixedKey}.${index}`] = value[index]; | |||
| const valueKey = `${prefixedKey}.${index}`; | |||
| if (typeof value[index] === 'object' && value[index] !== null) { | |||
There was a problem hiding this comment.
I think non-object filter needed on top of flattenObjectImpl function, but not sure to code convention of es-toolkit.
There was a problem hiding this comment.
Actually I think we have a simpler logic here; I made a little modification.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 306 306
Lines 2743 2747 +4
Branches 818 820 +2
=======================================
+ Hits 2742 2746 +4
Misses 1 1
|
raon0211
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #816