Added support for Apple Magic Trackpad 2 in bcm5974 driver #332

mwyborski · 2016-10-09T15:54:27Z

Incorporated the driver for the Apple Magic Trackpad 2 into the bcm5974 (MacBook Tochpad) driver. The Magic Trackpad 2 needs to be switched into the finger-reporting-mode, just like the other MacBook-Touchpads as well. But the format is different to the ones before. The Header is 12 Bytes long and each reported finger is additional 9 Bytes. The data order is as well different.

This is my first contribution. Please let me know if i have to change anything or submit the patch to someone else.

Kind regards
Marek

mwyborski · 2016-10-09T16:23:46Z

Ok. I already read, that pull-requests through github are not accepted. I contacted the maintainer via email.

fix stackoverflow in test_getdents64()

orospakr · 2017-05-01T14:10:38Z

Hi @robotrovsky, did you email the linux-input mailing list or the maintainer Henrik Rydberg directly?

mwyborski · 2017-05-01T20:12:25Z

Hi @orospakr ! Yes i wrote to Henrik Rydberg and he told me to submit the patch according to the guidelines. But i still don´t think, that the driver is complete this way. I would like to rewrite the driver alongside the Magic Trackpad I, but unfortunately i don't have time to do this right now. tiziano88/magic-trackpad-2-linux#4 (comment)

elbamos · 2017-05-15T05:22:44Z

@robotrovsky Is there a way I can help you?

mwyborski · 2017-05-15T08:11:23Z

Hi @elbamos! Thank you very much for your offer to help out. If you like to, you could port the driver over to magic trackpad I (magic mouse) driver, to get bluetooth working. Otherwise i think i will find some time to work on this the next two months. I already organized a USB Protocol Analyzer, to reverse engineer the protocol further, and make the settings adjustable (click firm, silent, etc...).

AlexCzar · 2017-06-15T05:05:07Z

Hi, @robotrovsky! Really appreciate your effort! What is the best place to track progress on this? As soon as it's in mainline I'm buying the M. pad :)

bithooked · 2017-07-06T16:06:49Z

Any update on this? I have an expensive MT2 collecting dust since I switched back to Linux full time. How can we help?

compressed · 2017-07-06T20:19:33Z

Yes, I'd love to see this as well. I can help with testing too.

I'm currently using https://github.com/robbi5/magictrackpad2-dkms on arch for the time being, it's a bit clunky (only works wired) using DKMS (and linux 4.11 caused some issues) but at least I can use the magic trackpad :)

bithooked · 2017-07-06T20:34:50Z

That's where I was headed next. I'm going to be trying it on Manjaro so it's good to hear it works on Arch before attempting it. Agreed, Bluetooth support would be great but I can deal with a wire for now.

There's also a thread on that project that explains better what needs to be done. tiziano88/magic-trackpad-2-linux#4

mwyborski · 2017-07-07T19:20:17Z

I have time this weekend and will prepare the patch nearly as-is according to the guidelines and send it to the mailinglist. I know i should have done this a long time ago.

mwyborski · 2017-07-08T01:08:54Z

Ok. So i send in the patch:
http://www.spinics.net/lists/kernel/msg2551703.html

Added support for Apple Magic Trackpad 2 in bcm5974 (MacBook Tochpad) driver. The Magic Trackpad 2 needs to be switched into the finger-reporting-mode, just like the other macbook touchpads as well. But the format is different to the ones before. The Header is 12 Bytes long and each reported finger is additional 9 Bytes. The data order is as well different. The driver currently only supports USB. One option would be to integrate bluetooth support into the bcm driver or to move the driver to the hid-magicmouse which supports bluetooth. I integrated the driver into the bcm and not the magicmouse driver, because this way i was able to compare the outcome with the macbook touchpad as i dont own a magicmouse or a magictrackpad. The patch has been tested by several people with a dkms: https://github.com/robbi5/magictrackpad2-dkms torvalds#332 Signed-off-by: Marek Wyborski <[email protected]>

Hubro · 2017-07-14T23:13:48Z

I absolutely love Apple's keyboards and mouse pads, but unfortunately I only use Linux. As soon as Magic TrackPad 2 works in Linux over Bluetooth with basic click, right click and scroll I'll buy one. I'd be happy to help test any unstable drivers.

anton-johansson · 2017-07-19T09:03:47Z

I'm eagerly waiting to be able to use my trackpad. Is there anywhere I can track progress of this change?

I'll gladly help testing aswell!

coxley · 2017-07-20T00:44:11Z

👍 Have been waiting for this for awhile.

zavorka · 2017-08-26T07:32:11Z

Awesome work! I was actually trying to decode some usbmon traces myself, fortunately I've discovered this PR before I actually dived deeper into it.

So with the kernel driver available, what is needed to be configured in the userspace (Xorg server) to get the pointer behavior close to the one we're used to from macOS?

postadelmaga · 2017-09-07T13:09:29Z

When can we expect this to be merged in the kernel tree ?

kingkian · 2017-09-14T16:16:22Z

+1!!!!

oscarbranson · 2017-09-28T05:09:46Z

+9000!

yselivonchyk · 2017-11-14T05:55:55Z

Is it possible to get it working under Gnome (which comes by default with 17.10) ?

arduino-man · 2017-12-03T17:27:25Z

Yes is it possible to get it working under Gnome. I am using it as we speak. Thumb rejection is not quite as fast as on the Mac OS (if your thumb and your index are both on the track pad it takes about 500 ms to start ignoring the thumb and let you move with the index) but this is an amazing driver.

yselivonchyk · 2017-12-03T17:54:03Z

@arduino-man can you please describe some steps of how to get it working? So far I have magictrackpad identified as a pointer device (pointer events only) on Ubuntu 17.10 and there is a this driver that I could not figure out how to bring in

arduino-man · 2017-12-03T18:50:12Z

I basically uninstalled everything that has "synaptic" in the name. Then proceeded to "sudo apt-get install xserver-xorg-input-libinput-hwe" after removing synaptic Linux immediately defaulted to libinput.

I used these commands to remove everything: sudo apt-get remove xserver-xorg-input-synaptics*

Then just reboot

[ Upstream commit e6f108b ] ipr_init() will not call unregister_reboot_notifier() when pci_register_driver() fails, which causes a WARNING. Call unregister_reboot_notifier() when pci_register_driver() fails. notifier callback ipr_halt [ipr] already registered WARNING: CPU: 3 PID: 299 at kernel/notifier.c:29 notifier_chain_register+0x16d/0x230 Modules linked in: ipr(+) xhci_pci_renesas xhci_hcd ehci_hcd usbcore led_class gpu_sched drm_buddy video wmi drm_ttm_helper ttm drm_display_helper drm_kms_helper drm drm_panel_orientation_quirks agpgart cfbft CPU: 3 PID: 299 Comm: modprobe Tainted: G W 6.1.0-rc1-00190-g39508d23b672-dirty torvalds#332 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.15.0-0-g2dd4b9b3f840-prebuilt.qemu.org 04/01/2014 RIP: 0010:notifier_chain_register+0x16d/0x230 Call Trace: <TASK> __blocking_notifier_chain_register+0x73/0xb0 ipr_init+0x30/0x1000 [ipr] do_one_initcall+0xdb/0x480 do_init_module+0x1cf/0x680 load_module+0x6a50/0x70a0 __do_sys_finit_module+0x12f/0x1c0 do_syscall_64+0x3f/0x90 entry_SYSCALL_64_after_hwframe+0x63/0xcd Fixes: f72919e ("[SCSI] ipr: implement shutdown changes and remove obsolete write cache parameter") Signed-off-by: Shang XiaoJing <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Martin K. Petersen <[email protected]> Signed-off-by: Sasha Levin <[email protected]>

Add a test case which replaces an active ingress qdisc while keeping the miniq in-tact during the transition period to the new clsact qdisc. # ./vmtest.sh -- ./test_progs -t tc_link [...] ./test_progs -t tc_link [ 3.412871] bpf_testmod: loading out-of-tree module taints kernel. [ 3.413343] bpf_testmod: module verification failed: signature and/or required key missing - tainting kernel torvalds#332 tc_links_after:OK torvalds#333 tc_links_append:OK torvalds#334 tc_links_basic:OK torvalds#335 tc_links_before:OK torvalds#336 tc_links_chain_classic:OK torvalds#337 tc_links_chain_mixed:OK torvalds#338 tc_links_dev_chain0:OK torvalds#339 tc_links_dev_cleanup:OK torvalds#340 tc_links_dev_mixed:OK torvalds#341 tc_links_ingress:OK torvalds#342 tc_links_invalid:OK torvalds#343 tc_links_prepend:OK torvalds#344 tc_links_replace:OK torvalds#345 tc_links_revision:OK Summary: 14/0 PASSED, 0 SKIPPED, 0 FAILED Signed-off-by: Daniel Borkmann <[email protected]> Cc: Martin KaFai Lau <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Martin KaFai Lau <[email protected]>

[ Upstream commit 5f1d18d ] Add a test case which replaces an active ingress qdisc while keeping the miniq in-tact during the transition period to the new clsact qdisc. # ./vmtest.sh -- ./test_progs -t tc_link [...] ./test_progs -t tc_link [ 3.412871] bpf_testmod: loading out-of-tree module taints kernel. [ 3.413343] bpf_testmod: module verification failed: signature and/or required key missing - tainting kernel torvalds#332 tc_links_after:OK torvalds#333 tc_links_append:OK torvalds#334 tc_links_basic:OK torvalds#335 tc_links_before:OK torvalds#336 tc_links_chain_classic:OK torvalds#337 tc_links_chain_mixed:OK torvalds#338 tc_links_dev_chain0:OK torvalds#339 tc_links_dev_cleanup:OK torvalds#340 tc_links_dev_mixed:OK torvalds#341 tc_links_ingress:OK torvalds#342 tc_links_invalid:OK torvalds#343 tc_links_prepend:OK torvalds#344 tc_links_replace:OK torvalds#345 tc_links_revision:OK Summary: 14/0 PASSED, 0 SKIPPED, 0 FAILED Signed-off-by: Daniel Borkmann <[email protected]> Cc: Martin KaFai Lau <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Martin KaFai Lau <[email protected]> Signed-off-by: Sasha Levin <[email protected]>

Add a test case which replaces an active ingress qdisc while keeping the miniq in-tact during the transition period to the new clsact qdisc. # ./vmtest.sh -- ./test_progs -t tc_link [...] ./test_progs -t tc_link [ 3.412871] bpf_testmod: loading out-of-tree module taints kernel. [ 3.413343] bpf_testmod: module verification failed: signature and/or required key missing - tainting kernel torvalds#332 tc_links_after:OK torvalds#333 tc_links_append:OK torvalds#334 tc_links_basic:OK torvalds#335 tc_links_before:OK torvalds#336 tc_links_chain_classic:OK torvalds#337 tc_links_chain_mixed:OK torvalds#338 tc_links_dev_chain0:OK torvalds#339 tc_links_dev_cleanup:OK torvalds#340 tc_links_dev_mixed:OK torvalds#341 tc_links_ingress:OK torvalds#342 tc_links_invalid:OK torvalds#343 tc_links_prepend:OK torvalds#344 tc_links_replace:OK torvalds#345 tc_links_revision:OK Summary: 14/0 PASSED, 0 SKIPPED, 0 FAILED Signed-off-by: Daniel Borkmann <[email protected]> Cc: Martin KaFai Lau <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Martin KaFai Lau <[email protected]>

Added support for Apple Magic Trackpad 2 in bcm5974 driver

7b50169

laijs pushed a commit to laijs/linux that referenced this pull request Feb 22, 2017

Merge pull request torvalds#332 from laijs/lkl/stackoverflow

84f6a9b

fix stackoverflow in test_getdents64()

Wyborski added 4 commits July 7, 2017 23:19

Merge remote-tracking branch 'upstream/master'

7276648

use local variables consistently

3a217b1

correct tabs

2276b81

correct email

fc64c8d

anton-johansson mentioned this pull request Jul 21, 2017

Installation instructions mwyborski/Linux-Magic-Trackpad-2-Driver#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for Apple Magic Trackpad 2 in bcm5974 driver #332

Added support for Apple Magic Trackpad 2 in bcm5974 driver #332

mwyborski commented Oct 9, 2016

mwyborski commented Oct 9, 2016

orospakr commented May 1, 2017

mwyborski commented May 1, 2017

elbamos commented May 15, 2017

mwyborski commented May 15, 2017

AlexCzar commented Jun 15, 2017

bithooked commented Jul 6, 2017

compressed commented Jul 6, 2017

bithooked commented Jul 6, 2017

mwyborski commented Jul 7, 2017

mwyborski commented Jul 8, 2017

Hubro commented Jul 14, 2017

anton-johansson commented Jul 19, 2017 •

edited

Loading

coxley commented Jul 20, 2017

zavorka commented Aug 26, 2017

postadelmaga commented Sep 7, 2017

kingkian commented Sep 14, 2017

oscarbranson commented Sep 28, 2017

yselivonchyk commented Nov 14, 2017

arduino-man commented Dec 3, 2017

yselivonchyk commented Dec 3, 2017

arduino-man commented Dec 3, 2017

Added support for Apple Magic Trackpad 2 in bcm5974 driver #332

Are you sure you want to change the base?

Added support for Apple Magic Trackpad 2 in bcm5974 driver #332

Conversation

mwyborski commented Oct 9, 2016

mwyborski commented Oct 9, 2016

orospakr commented May 1, 2017

mwyborski commented May 1, 2017

elbamos commented May 15, 2017

mwyborski commented May 15, 2017

AlexCzar commented Jun 15, 2017

bithooked commented Jul 6, 2017

compressed commented Jul 6, 2017

bithooked commented Jul 6, 2017

mwyborski commented Jul 7, 2017

mwyborski commented Jul 8, 2017

Hubro commented Jul 14, 2017

anton-johansson commented Jul 19, 2017 • edited Loading

coxley commented Jul 20, 2017

zavorka commented Aug 26, 2017

postadelmaga commented Sep 7, 2017

kingkian commented Sep 14, 2017

oscarbranson commented Sep 28, 2017

yselivonchyk commented Nov 14, 2017

arduino-man commented Dec 3, 2017

yselivonchyk commented Dec 3, 2017

arduino-man commented Dec 3, 2017

anton-johansson commented Jul 19, 2017 •

edited

Loading