iio:ak8975 : Fixed checkpatch warning #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please look at #192 :) |
laijs
pushed a commit
to laijs/linux
that referenced
this pull request
Feb 13, 2017
lkl: Fix lkl_add_neighbor close
wzyy2
pushed a commit
to wzyy2/linux
that referenced
this pull request
Feb 24, 2017
If iommu_map_sg is error, it's return value is zero, but rockchip_gem_iommu_map feel the zero return value is success, bug happen: [ 5.227458] [drm:rockchip_gem_iommu_map] *ERROR* failed to map buffer: 0 [ 12.291590] WARNING: at drivers/gpu/drm/drm_mm.c:369 [ 12.291611] Modules linked in: [ 12.291634] [ 12.291658] CPU: 4 PID: 338 Comm: cameraserver Not tainted 4.4.41 torvalds#196 [ 12.291680] Hardware name: rockchip,rk3399-mid (DT) [ 12.291703] task: ffffffc0e5a23100 ti: ffffffc0e5a64000 task.ti: ffffffc0e5a64000 [ 12.291739] PC is at drm_mm_remove_node+0xc/0xf8 [ 12.291766] LR is at rockchip_gem_iommu_unmap+0x3c/0x54 [ 12.303799] [<ffffff80084526e0>] drm_mm_remove_node+0xc/0xf8 [ 12.303827] [<ffffff8008475430>] rockchip_gem_free_object+0x98/0x168 [ 12.303854] [<ffffff8008449e80>] drm_gem_object_free+0x2c/0x34 [ 12.303878] [<ffffff80084626c4>] drm_gem_dmabuf_release+0x90/0xa4 [ 12.303904] [<ffffff80084ee73c>] dma_buf_release+0x64/0x15c [ 12.303929] [<ffffff80081aa8dc>] __fput+0xe0/0x1a4 [ 12.303950] [<ffffff80081aa9f8>] ____fput+0xc/0x14 [ 12.303977] [<ffffff80080b65ec>] task_work_run+0xa0/0xc0 [ 12.304004] [<ffffff8008087f18>] do_notify_resume+0x40/0x54 [ 12.304026] [<ffffff80080825e4>] work_pending+0x10/0x14 Change-Id: Id79c052691270553c1c60086f9926f39a5296354 Signed-off-by: Mark Yao <[email protected]>
fengguang
pushed a commit
to 0day-ci/linux
that referenced
this pull request
Sep 29, 2020
…adlock After base_lock which occupy by ath11k_regd_update, the softirq run for WMI_REG_CHAN_LIST_CC_EVENTID maybe arrived and it also need to accuire the spin lock, then deadlock happend, change to disable softirqis to solve it. [ 235.576990] ================================ [ 235.576991] WARNING: inconsistent lock state [ 235.576993] 5.9.0-rc5-wt-ath+ torvalds#196 Not tainted [ 235.576994] -------------------------------- [ 235.576995] inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage. [ 235.576997] kworker/u16:1/98 [HC0[0]:SC0[0]:HE1:SE1] takes: [ 235.576998] ffff9655f75cad98 (&ab->base_lock){+.?.}-{2:2}, at: ath11k_regd_update+0x28/0x1d0 [ath11k] [ 235.577009] {IN-SOFTIRQ-W} state was registered at: [ 235.577013] __lock_acquire+0x219/0x6e0 [ 235.577015] lock_acquire+0xb6/0x270 [ 235.577018] _raw_spin_lock+0x2c/0x70 [ 235.577023] ath11k_reg_chan_list_event.isra.0+0x10d/0x1e0 [ath11k] [ 235.577028] ath11k_wmi_tlv_op_rx+0x3c3/0x560 [ath11k] [ 235.577033] ath11k_htc_rx_completion_handler+0x207/0x370 [ath11k] [ 235.577039] ath11k_ce_recv_process_cb+0x15e/0x1e0 [ath11k] [ 235.577041] ath11k_pci_ce_tasklet+0x10/0x30 [ath11k_pci] [ 235.577043] tasklet_action_common.constprop.0+0xd4/0xf0 [ 235.577045] __do_softirq+0xc9/0x482 [ 235.577046] asm_call_on_stack+0x12/0x20 [ 235.577048] do_softirq_own_stack+0x49/0x60 [ 235.577049] irq_exit_rcu+0x9a/0xd0 [ 235.577050] common_interrupt+0xa1/0x190 [ 235.577052] asm_common_interrupt+0x1e/0x40 [ 235.577053] cpu_idle_poll.isra.0+0x2e/0x60 [ 235.577055] do_idle+0x5f/0xe0 [ 235.577056] cpu_startup_entry+0x14/0x20 [ 235.577058] start_kernel+0x443/0x464 [ 235.577060] secondary_startup_64+0xa4/0xb0 [ 235.577061] irq event stamp: 432035 [ 235.577063] hardirqs last enabled at (432035): [<ffffffff968d12b4>] _raw_spin_unlock_irqrestore+0x34/0x40 [ 235.577064] hardirqs last disabled at (432034): [<ffffffff968d10d3>] _raw_spin_lock_irqsave+0x63/0x80 [ 235.577066] softirqs last enabled at (431998): [<ffffffff967115c1>] inet6_fill_ifla6_attrs+0x3f1/0x430 [ 235.577067] softirqs last disabled at (431996): [<ffffffff9671159f>] inet6_fill_ifla6_attrs+0x3cf/0x430 [ 235.577068] [ 235.577068] other info that might help us debug this: [ 235.577069] Possible unsafe locking scenario: [ 235.577069] [ 235.577070] CPU0 [ 235.577070] ---- [ 235.577071] lock(&ab->base_lock); [ 235.577072] <Interrupt> [ 235.577073] lock(&ab->base_lock); [ 235.577074] [ 235.577074] *** DEADLOCK *** [ 235.577074] [ 235.577075] 3 locks held by kworker/u16:1/98: [ 235.577076] #0: ffff9655f75b1d48 ((wq_completion)ath11k_qmi_driver_event){+.+.}-{0:0}, at: process_one_work+0x1d3/0x5d0 [ 235.577079] #1: ffffa33cc02f3e70 ((work_completion)(&ab->qmi.event_work)){+.+.}-{0:0}, at: process_one_work+0x1d3/0x5d0 [ 235.577081] #2: ffff9655f75cad50 (&ab->core_lock){+.+.}-{3:3}, at: ath11k_core_qmi_firmware_ready.part.0+0x4e/0x160 [ath11k] [ 235.577087] [ 235.577087] stack backtrace: [ 235.577088] CPU: 3 PID: 98 Comm: kworker/u16:1 Not tainted 5.9.0-rc5-wt-ath+ torvalds#196 [ 235.577089] Hardware name: Intel(R) Client Systems NUC8i7HVK/NUC8i7HVB, BIOS HNKBLi70.86A.0049.2018.0801.1601 08/01/2018 [ 235.577095] Workqueue: ath11k_qmi_driver_event ath11k_qmi_driver_event_work [ath11k] [ 235.577096] Call Trace: [ 235.577100] dump_stack+0x77/0xa0 [ 235.577102] mark_lock_irq.cold+0x15/0x3c [ 235.577104] mark_lock+0x1d7/0x540 [ 235.577105] mark_usage+0xc7/0x140 [ 235.577107] __lock_acquire+0x219/0x6e0 [ 235.577108] ? sched_clock_cpu+0xc/0xb0 [ 235.577110] lock_acquire+0xb6/0x270 [ 235.577116] ? ath11k_regd_update+0x28/0x1d0 [ath11k] [ 235.577118] ? atomic_notifier_chain_register+0x2d/0x40 [ 235.577120] _raw_spin_lock+0x2c/0x70 [ 235.577125] ? ath11k_regd_update+0x28/0x1d0 [ath11k] [ 235.577130] ath11k_regd_update+0x28/0x1d0 [ath11k] [ 235.577136] __ath11k_mac_register+0x3fb/0x480 [ath11k] [ 235.577141] ath11k_mac_register+0x119/0x180 [ath11k] [ 235.577146] ath11k_core_pdev_create+0x17/0xe0 [ath11k] [ 235.577150] ath11k_core_qmi_firmware_ready.part.0+0x65/0x160 [ath11k] [ 235.577155] ath11k_qmi_driver_event_work+0x1c5/0x230 [ath11k] [ 235.577158] process_one_work+0x265/0x5d0 [ 235.577160] worker_thread+0x49/0x300 [ 235.577161] ? process_one_work+0x5d0/0x5d0 [ 235.577163] kthread+0x135/0x150 [ 235.577164] ? kthread_create_worker_on_cpu+0x60/0x60 [ 235.577166] ret_from_fork+0x22/0x30 Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1 Signed-off-by: Wen Gong <[email protected]> Signed-off-by: Kalle Valo <[email protected]>
fengguang
pushed a commit
to 0day-ci/linux
that referenced
this pull request
Sep 29, 2020
…u_desc With SLUB DEBUG CONFIG below crash is seen as kmem_cache_alloc is being called in non-atomic context. To fix this issue, use GFP_ATOMIC instead of GFP_KERNEL kzalloc. [ 357.217088] BUG: sleeping function called from invalid context at mm/slab.h:498 [ 357.217091] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 0, name: swapper/0 [ 357.217092] INFO: lockdep is turned off. [ 357.217095] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W 5.9.0-rc5-wt-ath+ torvalds#196 [ 357.217096] Hardware name: Intel(R) Client Systems NUC8i7HVK/NUC8i7HVB, BIOS HNKBLi70.86A.0049.2018.0801.1601 08/01/2018 [ 357.217097] Call Trace: [ 357.217098] <IRQ> [ 357.217107] ? ath11k_dp_htt_get_ppdu_desc+0xa9/0x170 [ath11k] [ 357.217110] dump_stack+0x77/0xa0 [ 357.217113] ___might_sleep.cold+0xa6/0xb6 [ 357.217116] kmem_cache_alloc_trace+0x1f2/0x270 [ 357.217122] ath11k_dp_htt_get_ppdu_desc+0xa9/0x170 [ath11k] [ 357.217129] ath11k_htt_pull_ppdu_stats.isra.0+0x96/0x270 [ath11k] [ 357.217135] ath11k_dp_htt_htc_t2h_msg_handler+0xe7/0x1d0 [ath11k] [ 357.217137] ? trace_hardirqs_on+0x1c/0x100 [ 357.217143] ath11k_htc_rx_completion_handler+0x207/0x370 [ath11k] [ 357.217149] ath11k_ce_recv_process_cb+0x15e/0x1e0 [ath11k] [ 357.217151] ? handle_irq_event+0x70/0xa8 [ 357.217154] ath11k_pci_ce_tasklet+0x10/0x30 [ath11k_pci] [ 357.217157] tasklet_action_common.constprop.0+0xd4/0xf0 [ 357.217160] __do_softirq+0xc9/0x482 [ 357.217162] asm_call_on_stack+0x12/0x20 [ 357.217163] </IRQ> [ 357.217166] do_softirq_own_stack+0x49/0x60 [ 357.217167] irq_exit_rcu+0x9a/0xd0 [ 357.217169] common_interrupt+0xa1/0x190 [ 357.217171] asm_common_interrupt+0x1e/0x40 [ 357.217173] RIP: 0010:cpu_idle_poll.isra.0+0x2e/0x60 [ 357.217175] Code: 8b 35 26 27 74 69 e8 11 c8 3d ff e8 bc fa 42 ff e8 e7 9f 4a ff fb 65 48 8b 1c 25 80 90 01 00 48 8b 03 a8 08 74 0b eb 1c f3 90 <48> 8b 03 a8 08 75 13 8b 0 [ 357.217177] RSP: 0018:ffffffff97403ee0 EFLAGS: 00000202 [ 357.217178] RAX: 0000000000000001 RBX: ffffffff9742b8c0 RCX: 0000000000b890ca [ 357.217180] RDX: 0000000000b890ca RSI: 0000000000000001 RDI: ffffffff968d0c49 [ 357.217181] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000001 [ 357.217182] R10: ffffffff9742b8c0 R11: 0000000000000046 R12: 0000000000000000 [ 357.217183] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000066fdf520 [ 357.217186] ? cpu_idle_poll.isra.0+0x19/0x60 [ 357.217189] do_idle+0x5f/0xe0 [ 357.217191] cpu_startup_entry+0x14/0x20 [ 357.217193] start_kernel+0x443/0x464 [ 357.217196] secondary_startup_64+0xa4/0xb0 Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1 Signed-off-by: Wen Gong <[email protected]> Signed-off-by: Kalle Valo <[email protected]>
ruscur
pushed a commit
to ruscur/linux
that referenced
this pull request
Oct 2, 2020
…adlock After base_lock which occupy by ath11k_regd_update, the softirq run for WMI_REG_CHAN_LIST_CC_EVENTID maybe arrived and it also need to accuire the spin lock, then deadlock happend, change to disable softirqis to solve it. [ 235.576990] ================================ [ 235.576991] WARNING: inconsistent lock state [ 235.576993] 5.9.0-rc5-wt-ath+ torvalds#196 Not tainted [ 235.576994] -------------------------------- [ 235.576995] inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage. [ 235.576997] kworker/u16:1/98 [HC0[0]:SC0[0]:HE1:SE1] takes: [ 235.576998] ffff9655f75cad98 (&ab->base_lock){+.?.}-{2:2}, at: ath11k_regd_update+0x28/0x1d0 [ath11k] [ 235.577009] {IN-SOFTIRQ-W} state was registered at: [ 235.577013] __lock_acquire+0x219/0x6e0 [ 235.577015] lock_acquire+0xb6/0x270 [ 235.577018] _raw_spin_lock+0x2c/0x70 [ 235.577023] ath11k_reg_chan_list_event.isra.0+0x10d/0x1e0 [ath11k] [ 235.577028] ath11k_wmi_tlv_op_rx+0x3c3/0x560 [ath11k] [ 235.577033] ath11k_htc_rx_completion_handler+0x207/0x370 [ath11k] [ 235.577039] ath11k_ce_recv_process_cb+0x15e/0x1e0 [ath11k] [ 235.577041] ath11k_pci_ce_tasklet+0x10/0x30 [ath11k_pci] [ 235.577043] tasklet_action_common.constprop.0+0xd4/0xf0 [ 235.577045] __do_softirq+0xc9/0x482 [ 235.577046] asm_call_on_stack+0x12/0x20 [ 235.577048] do_softirq_own_stack+0x49/0x60 [ 235.577049] irq_exit_rcu+0x9a/0xd0 [ 235.577050] common_interrupt+0xa1/0x190 [ 235.577052] asm_common_interrupt+0x1e/0x40 [ 235.577053] cpu_idle_poll.isra.0+0x2e/0x60 [ 235.577055] do_idle+0x5f/0xe0 [ 235.577056] cpu_startup_entry+0x14/0x20 [ 235.577058] start_kernel+0x443/0x464 [ 235.577060] secondary_startup_64+0xa4/0xb0 [ 235.577061] irq event stamp: 432035 [ 235.577063] hardirqs last enabled at (432035): [<ffffffff968d12b4>] _raw_spin_unlock_irqrestore+0x34/0x40 [ 235.577064] hardirqs last disabled at (432034): [<ffffffff968d10d3>] _raw_spin_lock_irqsave+0x63/0x80 [ 235.577066] softirqs last enabled at (431998): [<ffffffff967115c1>] inet6_fill_ifla6_attrs+0x3f1/0x430 [ 235.577067] softirqs last disabled at (431996): [<ffffffff9671159f>] inet6_fill_ifla6_attrs+0x3cf/0x430 [ 235.577068] [ 235.577068] other info that might help us debug this: [ 235.577069] Possible unsafe locking scenario: [ 235.577069] [ 235.577070] CPU0 [ 235.577070] ---- [ 235.577071] lock(&ab->base_lock); [ 235.577072] <Interrupt> [ 235.577073] lock(&ab->base_lock); [ 235.577074] [ 235.577074] *** DEADLOCK *** [ 235.577074] [ 235.577075] 3 locks held by kworker/u16:1/98: [ 235.577076] #0: ffff9655f75b1d48 ((wq_completion)ath11k_qmi_driver_event){+.+.}-{0:0}, at: process_one_work+0x1d3/0x5d0 [ 235.577079] #1: ffffa33cc02f3e70 ((work_completion)(&ab->qmi.event_work)){+.+.}-{0:0}, at: process_one_work+0x1d3/0x5d0 [ 235.577081] #2: ffff9655f75cad50 (&ab->core_lock){+.+.}-{3:3}, at: ath11k_core_qmi_firmware_ready.part.0+0x4e/0x160 [ath11k] [ 235.577087] [ 235.577087] stack backtrace: [ 235.577088] CPU: 3 PID: 98 Comm: kworker/u16:1 Not tainted 5.9.0-rc5-wt-ath+ torvalds#196 [ 235.577089] Hardware name: Intel(R) Client Systems NUC8i7HVK/NUC8i7HVB, BIOS HNKBLi70.86A.0049.2018.0801.1601 08/01/2018 [ 235.577095] Workqueue: ath11k_qmi_driver_event ath11k_qmi_driver_event_work [ath11k] [ 235.577096] Call Trace: [ 235.577100] dump_stack+0x77/0xa0 [ 235.577102] mark_lock_irq.cold+0x15/0x3c [ 235.577104] mark_lock+0x1d7/0x540 [ 235.577105] mark_usage+0xc7/0x140 [ 235.577107] __lock_acquire+0x219/0x6e0 [ 235.577108] ? sched_clock_cpu+0xc/0xb0 [ 235.577110] lock_acquire+0xb6/0x270 [ 235.577116] ? ath11k_regd_update+0x28/0x1d0 [ath11k] [ 235.577118] ? atomic_notifier_chain_register+0x2d/0x40 [ 235.577120] _raw_spin_lock+0x2c/0x70 [ 235.577125] ? ath11k_regd_update+0x28/0x1d0 [ath11k] [ 235.577130] ath11k_regd_update+0x28/0x1d0 [ath11k] [ 235.577136] __ath11k_mac_register+0x3fb/0x480 [ath11k] [ 235.577141] ath11k_mac_register+0x119/0x180 [ath11k] [ 235.577146] ath11k_core_pdev_create+0x17/0xe0 [ath11k] [ 235.577150] ath11k_core_qmi_firmware_ready.part.0+0x65/0x160 [ath11k] [ 235.577155] ath11k_qmi_driver_event_work+0x1c5/0x230 [ath11k] [ 235.577158] process_one_work+0x265/0x5d0 [ 235.577160] worker_thread+0x49/0x300 [ 235.577161] ? process_one_work+0x5d0/0x5d0 [ 235.577163] kthread+0x135/0x150 [ 235.577164] ? kthread_create_worker_on_cpu+0x60/0x60 [ 235.577166] ret_from_fork+0x22/0x30 Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1 Signed-off-by: Wen Gong <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/[email protected]
ruscur
pushed a commit
to ruscur/linux
that referenced
this pull request
Oct 2, 2020
…u_desc With SLUB DEBUG CONFIG below crash is seen as kmem_cache_alloc is being called in non-atomic context. To fix this issue, use GFP_ATOMIC instead of GFP_KERNEL kzalloc. [ 357.217088] BUG: sleeping function called from invalid context at mm/slab.h:498 [ 357.217091] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 0, name: swapper/0 [ 357.217092] INFO: lockdep is turned off. [ 357.217095] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W 5.9.0-rc5-wt-ath+ torvalds#196 [ 357.217096] Hardware name: Intel(R) Client Systems NUC8i7HVK/NUC8i7HVB, BIOS HNKBLi70.86A.0049.2018.0801.1601 08/01/2018 [ 357.217097] Call Trace: [ 357.217098] <IRQ> [ 357.217107] ? ath11k_dp_htt_get_ppdu_desc+0xa9/0x170 [ath11k] [ 357.217110] dump_stack+0x77/0xa0 [ 357.217113] ___might_sleep.cold+0xa6/0xb6 [ 357.217116] kmem_cache_alloc_trace+0x1f2/0x270 [ 357.217122] ath11k_dp_htt_get_ppdu_desc+0xa9/0x170 [ath11k] [ 357.217129] ath11k_htt_pull_ppdu_stats.isra.0+0x96/0x270 [ath11k] [ 357.217135] ath11k_dp_htt_htc_t2h_msg_handler+0xe7/0x1d0 [ath11k] [ 357.217137] ? trace_hardirqs_on+0x1c/0x100 [ 357.217143] ath11k_htc_rx_completion_handler+0x207/0x370 [ath11k] [ 357.217149] ath11k_ce_recv_process_cb+0x15e/0x1e0 [ath11k] [ 357.217151] ? handle_irq_event+0x70/0xa8 [ 357.217154] ath11k_pci_ce_tasklet+0x10/0x30 [ath11k_pci] [ 357.217157] tasklet_action_common.constprop.0+0xd4/0xf0 [ 357.217160] __do_softirq+0xc9/0x482 [ 357.217162] asm_call_on_stack+0x12/0x20 [ 357.217163] </IRQ> [ 357.217166] do_softirq_own_stack+0x49/0x60 [ 357.217167] irq_exit_rcu+0x9a/0xd0 [ 357.217169] common_interrupt+0xa1/0x190 [ 357.217171] asm_common_interrupt+0x1e/0x40 [ 357.217173] RIP: 0010:cpu_idle_poll.isra.0+0x2e/0x60 [ 357.217175] Code: 8b 35 26 27 74 69 e8 11 c8 3d ff e8 bc fa 42 ff e8 e7 9f 4a ff fb 65 48 8b 1c 25 80 90 01 00 48 8b 03 a8 08 74 0b eb 1c f3 90 <48> 8b 03 a8 08 75 13 8b 0 [ 357.217177] RSP: 0018:ffffffff97403ee0 EFLAGS: 00000202 [ 357.217178] RAX: 0000000000000001 RBX: ffffffff9742b8c0 RCX: 0000000000b890ca [ 357.217180] RDX: 0000000000b890ca RSI: 0000000000000001 RDI: ffffffff968d0c49 [ 357.217181] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000001 [ 357.217182] R10: ffffffff9742b8c0 R11: 0000000000000046 R12: 0000000000000000 [ 357.217183] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000066fdf520 [ 357.217186] ? cpu_idle_poll.isra.0+0x19/0x60 [ 357.217189] do_idle+0x5f/0xe0 [ 357.217191] cpu_startup_entry+0x14/0x20 [ 357.217193] start_kernel+0x443/0x464 [ 357.217196] secondary_startup_64+0xa4/0xb0 Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1 Signed-off-by: Wen Gong <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/[email protected]
heftig
referenced
this pull request
in zen-kernel/zen-kernel
Nov 5, 2020
…u_desc [ Upstream commit 6a8be1b ] With SLUB DEBUG CONFIG below crash is seen as kmem_cache_alloc is being called in non-atomic context. To fix this issue, use GFP_ATOMIC instead of GFP_KERNEL kzalloc. [ 357.217088] BUG: sleeping function called from invalid context at mm/slab.h:498 [ 357.217091] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 0, name: swapper/0 [ 357.217092] INFO: lockdep is turned off. [ 357.217095] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W 5.9.0-rc5-wt-ath+ #196 [ 357.217096] Hardware name: Intel(R) Client Systems NUC8i7HVK/NUC8i7HVB, BIOS HNKBLi70.86A.0049.2018.0801.1601 08/01/2018 [ 357.217097] Call Trace: [ 357.217098] <IRQ> [ 357.217107] ? ath11k_dp_htt_get_ppdu_desc+0xa9/0x170 [ath11k] [ 357.217110] dump_stack+0x77/0xa0 [ 357.217113] ___might_sleep.cold+0xa6/0xb6 [ 357.217116] kmem_cache_alloc_trace+0x1f2/0x270 [ 357.217122] ath11k_dp_htt_get_ppdu_desc+0xa9/0x170 [ath11k] [ 357.217129] ath11k_htt_pull_ppdu_stats.isra.0+0x96/0x270 [ath11k] [ 357.217135] ath11k_dp_htt_htc_t2h_msg_handler+0xe7/0x1d0 [ath11k] [ 357.217137] ? trace_hardirqs_on+0x1c/0x100 [ 357.217143] ath11k_htc_rx_completion_handler+0x207/0x370 [ath11k] [ 357.217149] ath11k_ce_recv_process_cb+0x15e/0x1e0 [ath11k] [ 357.217151] ? handle_irq_event+0x70/0xa8 [ 357.217154] ath11k_pci_ce_tasklet+0x10/0x30 [ath11k_pci] [ 357.217157] tasklet_action_common.constprop.0+0xd4/0xf0 [ 357.217160] __do_softirq+0xc9/0x482 [ 357.217162] asm_call_on_stack+0x12/0x20 [ 357.217163] </IRQ> [ 357.217166] do_softirq_own_stack+0x49/0x60 [ 357.217167] irq_exit_rcu+0x9a/0xd0 [ 357.217169] common_interrupt+0xa1/0x190 [ 357.217171] asm_common_interrupt+0x1e/0x40 [ 357.217173] RIP: 0010:cpu_idle_poll.isra.0+0x2e/0x60 [ 357.217175] Code: 8b 35 26 27 74 69 e8 11 c8 3d ff e8 bc fa 42 ff e8 e7 9f 4a ff fb 65 48 8b 1c 25 80 90 01 00 48 8b 03 a8 08 74 0b eb 1c f3 90 <48> 8b 03 a8 08 75 13 8b 0 [ 357.217177] RSP: 0018:ffffffff97403ee0 EFLAGS: 00000202 [ 357.217178] RAX: 0000000000000001 RBX: ffffffff9742b8c0 RCX: 0000000000b890ca [ 357.217180] RDX: 0000000000b890ca RSI: 0000000000000001 RDI: ffffffff968d0c49 [ 357.217181] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000001 [ 357.217182] R10: ffffffff9742b8c0 R11: 0000000000000046 R12: 0000000000000000 [ 357.217183] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000066fdf520 [ 357.217186] ? cpu_idle_poll.isra.0+0x19/0x60 [ 357.217189] do_idle+0x5f/0xe0 [ 357.217191] cpu_startup_entry+0x14/0x20 [ 357.217193] start_kernel+0x443/0x464 [ 357.217196] secondary_startup_64+0xa4/0xb0 Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1 Signed-off-by: Wen Gong <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Sasha Levin <[email protected]>
heftig
referenced
this pull request
in zen-kernel/zen-kernel
Nov 5, 2020
…adlock [ Upstream commit df64880 ] After base_lock which occupy by ath11k_regd_update, the softirq run for WMI_REG_CHAN_LIST_CC_EVENTID maybe arrived and it also need to accuire the spin lock, then deadlock happend, change to disable softirqis to solve it. [ 235.576990] ================================ [ 235.576991] WARNING: inconsistent lock state [ 235.576993] 5.9.0-rc5-wt-ath+ #196 Not tainted [ 235.576994] -------------------------------- [ 235.576995] inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage. [ 235.576997] kworker/u16:1/98 [HC0[0]:SC0[0]:HE1:SE1] takes: [ 235.576998] ffff9655f75cad98 (&ab->base_lock){+.?.}-{2:2}, at: ath11k_regd_update+0x28/0x1d0 [ath11k] [ 235.577009] {IN-SOFTIRQ-W} state was registered at: [ 235.577013] __lock_acquire+0x219/0x6e0 [ 235.577015] lock_acquire+0xb6/0x270 [ 235.577018] _raw_spin_lock+0x2c/0x70 [ 235.577023] ath11k_reg_chan_list_event.isra.0+0x10d/0x1e0 [ath11k] [ 235.577028] ath11k_wmi_tlv_op_rx+0x3c3/0x560 [ath11k] [ 235.577033] ath11k_htc_rx_completion_handler+0x207/0x370 [ath11k] [ 235.577039] ath11k_ce_recv_process_cb+0x15e/0x1e0 [ath11k] [ 235.577041] ath11k_pci_ce_tasklet+0x10/0x30 [ath11k_pci] [ 235.577043] tasklet_action_common.constprop.0+0xd4/0xf0 [ 235.577045] __do_softirq+0xc9/0x482 [ 235.577046] asm_call_on_stack+0x12/0x20 [ 235.577048] do_softirq_own_stack+0x49/0x60 [ 235.577049] irq_exit_rcu+0x9a/0xd0 [ 235.577050] common_interrupt+0xa1/0x190 [ 235.577052] asm_common_interrupt+0x1e/0x40 [ 235.577053] cpu_idle_poll.isra.0+0x2e/0x60 [ 235.577055] do_idle+0x5f/0xe0 [ 235.577056] cpu_startup_entry+0x14/0x20 [ 235.577058] start_kernel+0x443/0x464 [ 235.577060] secondary_startup_64+0xa4/0xb0 [ 235.577061] irq event stamp: 432035 [ 235.577063] hardirqs last enabled at (432035): [<ffffffff968d12b4>] _raw_spin_unlock_irqrestore+0x34/0x40 [ 235.577064] hardirqs last disabled at (432034): [<ffffffff968d10d3>] _raw_spin_lock_irqsave+0x63/0x80 [ 235.577066] softirqs last enabled at (431998): [<ffffffff967115c1>] inet6_fill_ifla6_attrs+0x3f1/0x430 [ 235.577067] softirqs last disabled at (431996): [<ffffffff9671159f>] inet6_fill_ifla6_attrs+0x3cf/0x430 [ 235.577068] [ 235.577068] other info that might help us debug this: [ 235.577069] Possible unsafe locking scenario: [ 235.577069] [ 235.577070] CPU0 [ 235.577070] ---- [ 235.577071] lock(&ab->base_lock); [ 235.577072] <Interrupt> [ 235.577073] lock(&ab->base_lock); [ 235.577074] [ 235.577074] *** DEADLOCK *** [ 235.577074] [ 235.577075] 3 locks held by kworker/u16:1/98: [ 235.577076] #0: ffff9655f75b1d48 ((wq_completion)ath11k_qmi_driver_event){+.+.}-{0:0}, at: process_one_work+0x1d3/0x5d0 [ 235.577079] #1: ffffa33cc02f3e70 ((work_completion)(&ab->qmi.event_work)){+.+.}-{0:0}, at: process_one_work+0x1d3/0x5d0 [ 235.577081] #2: ffff9655f75cad50 (&ab->core_lock){+.+.}-{3:3}, at: ath11k_core_qmi_firmware_ready.part.0+0x4e/0x160 [ath11k] [ 235.577087] [ 235.577087] stack backtrace: [ 235.577088] CPU: 3 PID: 98 Comm: kworker/u16:1 Not tainted 5.9.0-rc5-wt-ath+ #196 [ 235.577089] Hardware name: Intel(R) Client Systems NUC8i7HVK/NUC8i7HVB, BIOS HNKBLi70.86A.0049.2018.0801.1601 08/01/2018 [ 235.577095] Workqueue: ath11k_qmi_driver_event ath11k_qmi_driver_event_work [ath11k] [ 235.577096] Call Trace: [ 235.577100] dump_stack+0x77/0xa0 [ 235.577102] mark_lock_irq.cold+0x15/0x3c [ 235.577104] mark_lock+0x1d7/0x540 [ 235.577105] mark_usage+0xc7/0x140 [ 235.577107] __lock_acquire+0x219/0x6e0 [ 235.577108] ? sched_clock_cpu+0xc/0xb0 [ 235.577110] lock_acquire+0xb6/0x270 [ 235.577116] ? ath11k_regd_update+0x28/0x1d0 [ath11k] [ 235.577118] ? atomic_notifier_chain_register+0x2d/0x40 [ 235.577120] _raw_spin_lock+0x2c/0x70 [ 235.577125] ? ath11k_regd_update+0x28/0x1d0 [ath11k] [ 235.577130] ath11k_regd_update+0x28/0x1d0 [ath11k] [ 235.577136] __ath11k_mac_register+0x3fb/0x480 [ath11k] [ 235.577141] ath11k_mac_register+0x119/0x180 [ath11k] [ 235.577146] ath11k_core_pdev_create+0x17/0xe0 [ath11k] [ 235.577150] ath11k_core_qmi_firmware_ready.part.0+0x65/0x160 [ath11k] [ 235.577155] ath11k_qmi_driver_event_work+0x1c5/0x230 [ath11k] [ 235.577158] process_one_work+0x265/0x5d0 [ 235.577160] worker_thread+0x49/0x300 [ 235.577161] ? process_one_work+0x5d0/0x5d0 [ 235.577163] kthread+0x135/0x150 [ 235.577164] ? kthread_create_worker_on_cpu+0x60/0x60 [ 235.577166] ret_from_fork+0x22/0x30 Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1 Signed-off-by: Wen Gong <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Sasha Levin <[email protected]>
alistair23
pushed a commit
to alistair23/linux
that referenced
this pull request
Jan 31, 2021
Update 5.4-2.2.x-imx to stable v5.4.84
chombourger
pushed a commit
to chombourger/linux
that referenced
this pull request
Feb 16, 2021
…from plsdk-3125 to processor-sdk-linux-4.19.y * commit 'bcada72bd7ebad1ff5ef724f55af614fcc1c682a': ptp: cleanup timestamp event queue when extts is disabled
fengguang
pushed a commit
to 0day-ci/linux
that referenced
this pull request
Mar 15, 2021
This commit fixes the following checkpatch.pl errors:
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#70: FILE: ./hal/hal_btcoex.c:70:
+static u8 halbtcoutsrc_IsBtCoexistAvailable(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#104: FILE: ./hal/hal_btcoex.c:104:
+static void halbtcoutsrc_LeaveLps(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#117: FILE: ./hal/hal_btcoex.c:117:
+static void halbtcoutsrc_EnterLps(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#130: FILE: ./hal/hal_btcoex.c:130:
+static void halbtcoutsrc_NormalLps(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#152: FILE: ./hal/hal_btcoex.c:152:
+static void halbtcoutsrc_LeaveLowPower(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#187: FILE: ./hal/hal_btcoex.c:187:
+static void halbtcoutsrc_NormalLowPower(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#196: FILE: ./hal/hal_btcoex.c:196:
+static void halbtcoutsrc_DisableLowPower(struct BTC_COEXIST * pBtCoexist, u8 bLowPwrDisable)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#205: FILE: ./hal/hal_btcoex.c:205:
+static void halbtcoutsrc_AggregationCheck(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#283: FILE: ./hal/hal_btcoex.c:283:
+static u32 halbtcoutsrc_GetWifiLinkStatus(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#311: FILE: ./hal/hal_btcoex.c:311:
+static u32 halbtcoutsrc_GetBtPatchVer(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#342: FILE: ./hal/hal_btcoex.c:342:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#448: FILE: ./hal/hal_btcoex.c:448:
+ struct RT_LINK_DETECT_T * plinkinfo;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#510: FILE: ./hal/hal_btcoex.c:510:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#645: FILE: ./hal/hal_btcoex.c:645:
+static void halbtcoutsrc_DisplayFwPwrModeCmd(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#661: FILE: ./hal/hal_btcoex.c:661:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#673: FILE: ./hal/hal_btcoex.c:673:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#685: FILE: ./hal/hal_btcoex.c:685:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#697: FILE: ./hal/hal_btcoex.c:697:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#709: FILE: ./hal/hal_btcoex.c:709:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#749: FILE: ./hal/hal_btcoex.c:749:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#761: FILE: ./hal/hal_btcoex.c:761:
+ struct BTC_COEXIST * pBtCoexist = (struct BTC_COEXIST *)pBtcContext;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#772: FILE: ./hal/hal_btcoex.c:772:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#785: FILE: ./hal/hal_btcoex.c:785:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#797: FILE: ./hal/hal_btcoex.c:797:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#809: FILE: ./hal/hal_btcoex.c:809:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#821: FILE: ./hal/hal_btcoex.c:821:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#857: FILE: ./hal/hal_btcoex.c:857:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#869: FILE: ./hal/hal_btcoex.c:869:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#891: FILE: ./hal/hal_btcoex.c:891:
+ struct BTC_COEXIST * pBtCoexist = &GLBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#917: FILE: ./hal/hal_btcoex.c:917:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#963: FILE: ./hal/hal_btcoex.c:963:
+void EXhalbtcoutsrc_PowerOnSetting(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#975: FILE: ./hal/hal_btcoex.c:975:
+void EXhalbtcoutsrc_InitHwConfig(struct BTC_COEXIST * pBtCoexist, u8 bWifiOnly)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#988: FILE: ./hal/hal_btcoex.c:988:
+void EXhalbtcoutsrc_InitCoexDm(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1003: FILE: ./hal/hal_btcoex.c:1003:
+void EXhalbtcoutsrc_IpsNotify(struct BTC_COEXIST * pBtCoexist, u8 type)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1030: FILE: ./hal/hal_btcoex.c:1030:
+void EXhalbtcoutsrc_LpsNotify(struct BTC_COEXIST * pBtCoexist, u8 type)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1053: FILE: ./hal/hal_btcoex.c:1053:
+void EXhalbtcoutsrc_ScanNotify(struct BTC_COEXIST * pBtCoexist, u8 type)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1082: FILE: ./hal/hal_btcoex.c:1082:
+void EXhalbtcoutsrc_ConnectNotify(struct BTC_COEXIST * pBtCoexist, u8 action)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1108: FILE: ./hal/hal_btcoex.c:1108:
+void EXhalbtcoutsrc_MediaStatusNotify(struct BTC_COEXIST * pBtCoexist, enum RT_MEDIA_STATUS mediaStatus)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1135: FILE: ./hal/hal_btcoex.c:1135:
+void EXhalbtcoutsrc_SpecialPacketNotify(struct BTC_COEXIST * pBtCoexist, u8 pktType)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1166: FILE: ./hal/hal_btcoex.c:1166:
+void EXhalbtcoutsrc_BtInfoNotify(struct BTC_COEXIST * pBtCoexist, u8 *tmpBuf, u8 length)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1184: FILE: ./hal/hal_btcoex.c:1184:
+void EXhalbtcoutsrc_HaltNotify(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1197: FILE: ./hal/hal_btcoex.c:1197:
+void EXhalbtcoutsrc_PnpNotify(struct BTC_COEXIST * pBtCoexist, u8 pnpState)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1213: FILE: ./hal/hal_btcoex.c:1213:
+void EXhalbtcoutsrc_Periodical(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1258: FILE: ./hal/hal_btcoex.c:1258:
+void EXhalbtcoutsrc_DisplayBtCoexInfo(struct BTC_COEXIST * pBtCoexist)
Signed-off-by: Marco Cesati <[email protected]>
fengguang
pushed a commit
to 0day-ci/linux
that referenced
this pull request
Mar 16, 2021
This commit fixes the following checkpatch.pl errors:
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#70: FILE: ./hal/hal_btcoex.c:70:
+static u8 halbtcoutsrc_IsBtCoexistAvailable(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#104: FILE: ./hal/hal_btcoex.c:104:
+static void halbtcoutsrc_LeaveLps(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#117: FILE: ./hal/hal_btcoex.c:117:
+static void halbtcoutsrc_EnterLps(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#130: FILE: ./hal/hal_btcoex.c:130:
+static void halbtcoutsrc_NormalLps(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#152: FILE: ./hal/hal_btcoex.c:152:
+static void halbtcoutsrc_LeaveLowPower(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#187: FILE: ./hal/hal_btcoex.c:187:
+static void halbtcoutsrc_NormalLowPower(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#196: FILE: ./hal/hal_btcoex.c:196:
+static void halbtcoutsrc_DisableLowPower(struct BTC_COEXIST * pBtCoexist, u8 bLowPwrDisable)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#205: FILE: ./hal/hal_btcoex.c:205:
+static void halbtcoutsrc_AggregationCheck(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#283: FILE: ./hal/hal_btcoex.c:283:
+static u32 halbtcoutsrc_GetWifiLinkStatus(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#311: FILE: ./hal/hal_btcoex.c:311:
+static u32 halbtcoutsrc_GetBtPatchVer(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#342: FILE: ./hal/hal_btcoex.c:342:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#448: FILE: ./hal/hal_btcoex.c:448:
+ struct RT_LINK_DETECT_T * plinkinfo;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#510: FILE: ./hal/hal_btcoex.c:510:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#645: FILE: ./hal/hal_btcoex.c:645:
+static void halbtcoutsrc_DisplayFwPwrModeCmd(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#661: FILE: ./hal/hal_btcoex.c:661:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#673: FILE: ./hal/hal_btcoex.c:673:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#685: FILE: ./hal/hal_btcoex.c:685:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#697: FILE: ./hal/hal_btcoex.c:697:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#709: FILE: ./hal/hal_btcoex.c:709:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#749: FILE: ./hal/hal_btcoex.c:749:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#761: FILE: ./hal/hal_btcoex.c:761:
+ struct BTC_COEXIST * pBtCoexist = (struct BTC_COEXIST *)pBtcContext;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#772: FILE: ./hal/hal_btcoex.c:772:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#785: FILE: ./hal/hal_btcoex.c:785:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#797: FILE: ./hal/hal_btcoex.c:797:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#809: FILE: ./hal/hal_btcoex.c:809:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#821: FILE: ./hal/hal_btcoex.c:821:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#857: FILE: ./hal/hal_btcoex.c:857:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#869: FILE: ./hal/hal_btcoex.c:869:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#891: FILE: ./hal/hal_btcoex.c:891:
+ struct BTC_COEXIST * pBtCoexist = &GLBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#917: FILE: ./hal/hal_btcoex.c:917:
+ struct BTC_COEXIST * pBtCoexist;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#963: FILE: ./hal/hal_btcoex.c:963:
+void EXhalbtcoutsrc_PowerOnSetting(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#975: FILE: ./hal/hal_btcoex.c:975:
+void EXhalbtcoutsrc_InitHwConfig(struct BTC_COEXIST * pBtCoexist, u8 bWifiOnly)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#988: FILE: ./hal/hal_btcoex.c:988:
+void EXhalbtcoutsrc_InitCoexDm(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1003: FILE: ./hal/hal_btcoex.c:1003:
+void EXhalbtcoutsrc_IpsNotify(struct BTC_COEXIST * pBtCoexist, u8 type)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1030: FILE: ./hal/hal_btcoex.c:1030:
+void EXhalbtcoutsrc_LpsNotify(struct BTC_COEXIST * pBtCoexist, u8 type)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1053: FILE: ./hal/hal_btcoex.c:1053:
+void EXhalbtcoutsrc_ScanNotify(struct BTC_COEXIST * pBtCoexist, u8 type)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1082: FILE: ./hal/hal_btcoex.c:1082:
+void EXhalbtcoutsrc_ConnectNotify(struct BTC_COEXIST * pBtCoexist, u8 action)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1108: FILE: ./hal/hal_btcoex.c:1108:
+void EXhalbtcoutsrc_MediaStatusNotify(struct BTC_COEXIST * pBtCoexist, enum RT_MEDIA_STATUS mediaStatus)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1135: FILE: ./hal/hal_btcoex.c:1135:
+void EXhalbtcoutsrc_SpecialPacketNotify(struct BTC_COEXIST * pBtCoexist, u8 pktType)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1166: FILE: ./hal/hal_btcoex.c:1166:
+void EXhalbtcoutsrc_BtInfoNotify(struct BTC_COEXIST * pBtCoexist, u8 *tmpBuf, u8 length)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1184: FILE: ./hal/hal_btcoex.c:1184:
+void EXhalbtcoutsrc_HaltNotify(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1197: FILE: ./hal/hal_btcoex.c:1197:
+void EXhalbtcoutsrc_PnpNotify(struct BTC_COEXIST * pBtCoexist, u8 pnpState)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1213: FILE: ./hal/hal_btcoex.c:1213:
+void EXhalbtcoutsrc_Periodical(struct BTC_COEXIST * pBtCoexist)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1258: FILE: ./hal/hal_btcoex.c:1258:
+void EXhalbtcoutsrc_DisplayBtCoexInfo(struct BTC_COEXIST * pBtCoexist)
Reviewed-by: Dan Carpenter <[email protected]>
Signed-off-by: Marco Cesati <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
TheSven73
pushed a commit
to TheSven73/linux
that referenced
this pull request
Apr 16, 2021
Support for 32-bit arm
intel-lab-lkp
pushed a commit
to intel-lab-lkp/linux
that referenced
this pull request
Mar 8, 2023
The current codebase calls the function no matter net device has XDP programs or not. So the finalize function is being called everytime when RX bottom-half in progress. It needs a few machine instructions for nothing in the case that XDP programs are not attached at all. Lets it call the function on a condition that if xdp_status variable has not zero value. That means XDP programs are attached to the net device and it should be finalized based on the variable. The following instructions show that it's better than calling the function unconditionally. 0.31 │6b8: ldr w0, [sp, torvalds#196] │ ┌──cbz w0, 6cc │ │ mov x1, x0 │ │ mov x0, x27 │ │→ bl stmmac_finalize_xdp_rx │6cc:└─→ldr x1, [sp, torvalds#176] with 'if (xdp_status)' statement, jump to '6cc' label if xdp_status has zero value. Signed-off-by: Leesoo Ahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the AsahiKASEI magnetometer sensor compatible string.