Skip to content

Commit

Permalink
Revert "blk-rq-qos: remove redundant finish_wait to rq_qos_wait."
Browse files Browse the repository at this point in the history
This reverts commit 826f2f4.

Qian Cai reports that this commit causes stalls with swap. Revert until
the reason can be figured out.

Reported-by: Qian Cai <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
  • Loading branch information
axboe committed Jul 15, 2020
1 parent d0f0f1b commit e791ee6
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions block/blk-rq-qos.c
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,8 @@ void rq_qos_wait(struct rq_wait *rqw, void *private_data,
if (data.got_token)
break;
if (!has_sleeper && acquire_inflight_cb(rqw, private_data)) {
finish_wait(&rqw->wait, &data.wq);

/*
* We raced with wbt_wake_function() getting a token,
* which means we now have two. Put our local token
Expand Down

0 comments on commit e791ee6

Please sign in to comment.