Skip to content

Commit

Permalink
ACPI / APEI: Remove spurious GHES_TO_CLEAR check
Browse files Browse the repository at this point in the history
ghes_notify_nmi() checks ghes->flags for GHES_TO_CLEAR before going
on to __process_error(). This is pointless as ghes_read_estatus()
will always set this flag if it returns success, which was checked
earlier in the loop. Remove it.

Signed-off-by: James Morse <[email protected]>
Reviewed-by: Borislav Petkov <[email protected]>
Signed-off-by: Rafael J. Wysocki <[email protected]>
  • Loading branch information
James Morse authored and rafaeljw committed Feb 7, 2019
1 parent eeb2555 commit 7d49f2c
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/acpi/apei/ghes.c
Original file line number Diff line number Diff line change
Expand Up @@ -940,9 +940,6 @@ static int ghes_notify_nmi(unsigned int cmd, struct pt_regs *regs)
__ghes_panic(ghes, buf_paddr);
}

if (!(ghes->flags & GHES_TO_CLEAR))
continue;

__process_error(ghes);
ghes_clear_estatus(ghes, buf_paddr);
}
Expand Down

0 comments on commit 7d49f2c

Please sign in to comment.